chore(Dockerfile): bump go version #3845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
walldiss and
cristaloleg
as code owners
|
1.23 version should automatically pick up latest patch version of golang |
|
Elaborate? |
|
Hmm, looks right, then why was the go version was 1.23.0 🤔 |
|
Perhaps your image was build at time, when 1.23 was pointing to 1.23.0. If you rebuild new one, it should use 1.23.2 |
|
2 weeks ago, while image was build over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed
godebug asynctimerchan=1in #3790 and forgot to update the Dockerfile to the latest version of Go, resulting in images being built with go1.23.0 reproducing the original bug.