Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pruner/light): add light pruning for shwap #3896

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Oct 28, 2024

Light availability will now implement Pruner interface. It is logical step since Prune is the opposite of ShareAvailable. Mostly due to internal shared sync primitives, storage and private encoding structs. Refactoring of Pruner interface is not intended in this PR. It will be done in another PR where Pruner interface will be coupled with Availability interface.

@walldiss walldiss added the kind:feat Attached to feature PRs label Oct 28, 2024
@walldiss walldiss self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 40.42553% with 28 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (2469e7a) to head (7c54ac7).
Report is 373 commits behind head on main.

Files with missing lines Patch % Lines
share/availability/light/availability.go 37.77% 20 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3896      +/-   ##
==========================================
+ Coverage   44.83%   45.47%   +0.64%     
==========================================
  Files         265      307      +42     
  Lines       14620    21825    +7205     
==========================================
+ Hits         6555     9926    +3371     
- Misses       7313    10835    +3522     
- Partials      752     1064     +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss marked this pull request as ready for review November 1, 2024 12:30
nodebuilder/share/module.go Show resolved Hide resolved
share/availability/light/availability.go Outdated Show resolved Hide resolved
share/availability/light/availability.go Show resolved Hide resolved
share/availability/light/availability.go Show resolved Hide resolved
share/availability/light/availability.go Outdated Show resolved Hide resolved
share/availability/light/availability.go Outdated Show resolved Hide resolved
@walldiss walldiss enabled auto-merge (squash) November 1, 2024 15:17
@walldiss walldiss merged commit 1fbb040 into celestiaorg:main Nov 1, 2024
30 checks passed
@Wondertan Wondertan deleted the add-light-pruning branch November 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants