Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod) bump go-square #3958

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Nov 22, 2024

Bump go-square version + add a test to ensure that the fix works.

Closes #3956

Screenshot 2024-11-22 at 16 06 07

@vgonkivs vgonkivs added area:state Related to fetching state and state execution kind:deps Pull requests that update a dependency file kind:fix Attached to bug-fixing PRs area:blob labels Nov 22, 2024
@vgonkivs vgonkivs self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.62%. Comparing base (2469e7a) to head (84c75b3).
Report is 393 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3958      +/-   ##
==========================================
+ Coverage   44.83%   45.62%   +0.78%     
==========================================
  Files         265      308      +43     
  Lines       14620    21910    +7290     
==========================================
+ Hits         6555     9996    +3441     
- Misses       7313    10852    +3539     
- Partials      752     1062     +310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

cristaloleg
cristaloleg previously approved these changes Nov 22, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to do proper release on go-square?

cristaloleg
cristaloleg previously approved these changes Nov 25, 2024
walldiss
walldiss previously approved these changes Nov 25, 2024
@vgonkivs vgonkivs dismissed stale reviews from walldiss and cristaloleg via 47d2cb0 November 25, 2024 12:30
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things in tests

walldiss
walldiss previously approved these changes Nov 25, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding test

nodebuilder/tests/api_test.go Show resolved Hide resolved
@renaynay renaynay enabled auto-merge (squash) November 25, 2024 15:21
@vgonkivs vgonkivs disabled auto-merge November 25, 2024 15:33
@vgonkivs vgonkivs enabled auto-merge (squash) November 25, 2024 15:33
@vgonkivs vgonkivs merged commit f019e10 into celestiaorg:main Nov 25, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob area:state Related to fetching state and state execution kind:deps Pull requests that update a dependency file kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libshare.Blob json marshaling is broken, making state.SubmitPayForBlob unusable
5 participants