Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Good naming practice #179

Closed
andrijamitrovic23 opened this issue Jun 20, 2023 · 0 comments · Fixed by #185
Closed

Good naming practice #179

andrijamitrovic23 opened this issue Jun 20, 2023 · 0 comments · Fixed by #185
Assignees
@rootulp
Labels
audit

Comments

@andrijamitrovic23
Copy link

Using same name eds for the object pointer and the returned value is confusing in function deepCopy. It can lead you to a false conclusion that deep copying is not done in the function.

A different name for the return object should be used to avoid the confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: improve var name rootulp/rsmt2d
3 participants
@rootulp @liamsi @andrijamitrovic23