You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First part of naming of test cases in TestCorruptedEdsReturnsErrByzantineData is confusing. There are two possible ways to understand what does the naming refer to, and both of them are not completely right:
Bad Row or Column refers to the one Axis that should be returned as a part of the byzData. Trough debugging it has been confirmed that only for the third test case there is a overlapping between a name and the returned axis.
Bad Row or Column refers to the corruption of data within a row or a column but this is not true for the fourth test case.
Maybe just use the second part of naming (after “/“) which refers to will the original or extended data be corrupted.
The text was updated successfully, but these errors were encountered:
First part of naming of test cases in TestCorruptedEdsReturnsErrByzantineData is confusing. There are two possible ways to understand what does the naming refer to, and both of them are not completely right:
Bad Row or Column refers to the one Axis that should be returned as a part of the
byzData
. Trough debugging it has been confirmed that only for the third test case there is a overlapping between a name and the returned axis.Bad Row or Column refers to the corruption of data within a row or a column but this is not true for the fourth test case.
Maybe just use the second part of naming (after “/“) which refers to will the original or extended data be corrupted.
The text was updated successfully, but these errors were encountered: