Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate shares in ErrByzantineData #190

Merged
merged 7 commits into from
Jul 5, 2023
Merged

fix: populate shares in ErrByzantineData #190

merged 7 commits into from
Jul 5, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 21, 2023 •
edited
Loading

Closes #178

@rootulp rootulp self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #190 (7b9b799) into master (ed26fa9) will increase coverage by 0.97%.
The diff coverage is 14.28%.

❗ Current head 7b9b799 differs from pull request most recent head 4ecdaac. Consider uploading reports for the commit 4ecdaac to get more accurate results

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   80.93%   81.90%   +0.97%     
==========================================
  Files           7        7              
  Lines         493      503      +10     
==========================================
+ Hits          399      412      +13     
  Misses         56       56              
+ Partials       38       35       -3
Impacted Files Coverage Δ
extendeddatacrossword.go 73.51% <0.00%> (+2.56%) ⬆️
datasquare.go 95.18% <100.00%> (+0.11%) ⬆️

@rootulp rootulp added blocked bug Something isn't working labels Jun 30, 2023
@rootulp rootulp requested review from staheri14 and evan-forbes June 30, 2023 19:13
@staheri14 staheri14 mentioned this pull request Jul 3, 2023
Closed
@rootulp rootulp marked this pull request as ready for review July 4, 2023 14:13
@rootulp rootulp requested review from staheri14 and adlerjohn July 4, 2023 14:34
staheri14
staheri14 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! also liked your test documentation 👍

@rootulp rootulp removed the blocked label Jul 5, 2023
evan-forbes
evan-forbes approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simple solution LGTM!

@rootulp rootulp merged commit 47826b0 into celestiaorg:master Jul 5, 2023
@rootulp rootulp deleted the rp/populate-shares branch July 5, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@staheri14 staheri14 staheri14 approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@rootulp rootulp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrByzantineData.Shares are not filled
3 participants
@rootulp @staheri14 @evan-forbes