Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify shares inside ErrByzantineData #207

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 3, 2023

Closes #64 and motivated by #178 (comment)

@rootulp rootulp requested review from adlerjohn and staheri14 July 3, 2023 20:04
@rootulp rootulp self-assigned this Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #207 (9df24b4) into master (2557620) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files           7        7           
  Lines         500      500           
=======================================
  Hits          404      404           
  Misses         57       57           
  Partials       39       39           
Impacted Files Coverage Δ
extendeddatacrossword.go 70.94% <ø> (ø)

@evan-forbes
Copy link
Member

nice

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp merged commit 90b998f into celestiaorg:master Jul 4, 2023
@rootulp rootulp deleted the rp/clarify-shares branch July 4, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify guarantees of BE errors
3 participants