Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make consistent names for row and col indexes #317

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Apr 17, 2024

This PR standardizes index naming for rows and columns across the codebase to rowIdx and colIdx.

Resolves #314

@walldiss walldiss self-assigned this Apr 17, 2024
@walldiss walldiss requested review from rootulp and staheri14 April 17, 2024 12:25
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 86.13861% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 82.96%. Comparing base (d6c118c) to head (c116d1f).
Report is 19 commits behind head on main.

Files Patch % Lines
extendeddatacrossword.go 75.00% 7 Missing and 2 partials ⚠️
datasquare.go 89.13% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   80.89%   82.96%   +2.06%     
==========================================
  Files           8        7       -1     
  Lines         869      628     -241     
==========================================
- Hits          703      521     -182     
+ Misses        119       65      -54     
+ Partials       47       42       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rootulp rootulp removed their request for review April 18, 2024 15:49
@walldiss walldiss merged commit 34bcd7b into celestiaorg:main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names 2d coordinates of Row/Col are misleading. X, Y instead of Y, X
3 participants