Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet should use react-native-sms to send SMS invites for both iOS and Android #1553

Closed
jeanregisser opened this issue Oct 31, 2019 · 1 comment
Closed

Wallet should use react-native-sms to send SMS invites for both iOS and Android #1553

jeanregisser opened this issue Oct 31, 2019 · 1 comment
Labels
Priority: P3 Minor tech-debt triaged label for issues that have been assigned a priority wallet

Comments

@jeanregisser
Copy link
Contributor

Expected Behavior

Wallet should use react-native-sms to send SMS invites for both iOS and Android

Current Behavior

react-native-sms was used to implement the SMS invite on iOS.
See #1541
This library can be used for both iOS and Android and we should now use it for Android too to avoid having to maintain 2 different JS implementations.
@jeanregisser jeanregisser mentioned this issue Oct 31, 2019
Merged
@jmrossy jmrossy added Priority: P3 Minor triaged label for issues that have been assigned a priority labels Oct 31, 2019
@tarikbellamine
Copy link
Contributor

Duplicate of #3693

@lili2311 lili2311 mentioned this issue Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P3 Minor tech-debt triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeanregisser @jmrossy @tarikbellamine