This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Resource per metric #224
Merged
Resource per metric #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 73.02% 73.39% +0.37%
==========================================
Files 15 15
Lines 1609 1609
==========================================
+ Hits 1175 1181 +6
+ Misses 355 351 -4
+ Partials 79 77 -2
Continue to review full report at Codecov.
|
songy23
reviewed
Sep 18, 2019
metrics_proto_api_test.go
Outdated
| @@ -85,6 +86,74 @@ func TestVariousCasesFromFile(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMetricsWithPrefix(t *testing.T) { | |||
| server, addr, doneFn := createFakeServer(t) | |||
There was a problem hiding this comment.
Nit: looks like these few lines appear multiple times. How about having a func createFakeServerAndConn that returns both the server and connection? The returned doneFn can incorporate conn.Close() too.
|
|
||
| tc := readTestCaseFromFiles(t, "SingleMetric") | ||
|
|
||
| prefixes := []string{ |
There was a problem hiding this comment.
Nit: can also test "external.googleapis.com/prometheus/".
- also modify createFakeServer to return server and connectio
songy23
approved these changes
Sep 18, 2019
metrics_proto_api_test.go
Outdated
| stop := func() { | ||
| srv.Stop() | ||
| _ = ln.Close() | ||
| conn.Close() |
There was a problem hiding this comment.
Nit: I think conn needs to be closed first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test for