This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
update PushTraceSpans to return dropped spans instead of good spans. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibawt PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 72.24% 72.11% -0.14%
==========================================
Files 14 14
Lines 1643 1646 +3
==========================================
Hits 1187 1187
- Misses 380 383 +3
Partials 76 76
Continue to review full report at Codecov.
|
dinooliva
reviewed
Feb 7, 2020
trace.go
Outdated
| @@ -148,7 +148,8 @@ func (e *traceExporter) pushTraceSpans(ctx context.Context, node *commonpb.Node, | |||
| ctx, cancel := newContextWithTimeout(ctx, e.o.Timeout) | |||
| defer cancel() | |||
|
|
|||
| return e.client.BatchWriteSpans(ctx, &req) | |||
| err := e.client.BatchWriteSpans(ctx, &req) | |||
| return 0, err | |||
There was a problem hiding this comment.
There will never be any dropped spans for stackdriver, is that correct?
There was a problem hiding this comment.
I think if err is not nil, we should return len(protoSpans) here.
There was a problem hiding this comment.
@dinooliva it will be all or none.
@songy23 fixed it.
dinooliva
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #250