This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Skip adding display name prefix for metrics with custom domain #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
force-pushed
the
fix-display-name-prefix
branch
from
203f813 to
572977f
Compare
nilebox
force-pushed
the
fix-display-name-prefix
branch
from
572977f to
e3c7f0c
Compare
james-bebbington
approved these changes
Aug 11, 2020
|
Seems like a reasonable change for now, and changing Display Names should be safe afaiu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix (though a bit hacky) for the following problem: when a metric name is prefixed with a custom domain, the generated display name is pretty long and confusing.
e.g. for metric
external.googleapis.com/user/my_metricthe display name isOpenCensus/external.googleapis.com/user/my_metric.Also, since we use this exporter in OpenTelemetry collector, having
OpenCensus/as a prefix on all metrics is pretty confusing as well.This fix just removes the redundant
OpenCensus/prefix from such metrics as a quick workaround.Ideally we may want to also consider removing domain from the display name as well, but that requires more changes in configuration and overall code.