Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker pool for diffing off of the chainEvent channel #41

Closed
i-norden opened this issue Nov 18, 2020 · 1 comment
Closed

Worker pool for diffing off of the chainEvent channel #41

i-norden opened this issue Nov 18, 2020 · 1 comment
Assignees
@roysc

Comments

@i-norden
Copy link
Collaborator

i-norden commented Nov 18, 2020 •
edited
Loading

Maintaining sequential order is no longer a priority, process the blocks off of the chainEvent chan concurrently using a statediff.Builder worker pool

e.g. here: https://github.com/vulcanize/go-ethereum/blob/v1.9.24-statediff/statediff/service.go#L196

This will require some rework of the lastBlock cache and the trie dereferencing to prevent race conditions.
@roysc roysc mentioned this issue Nov 19, 2020
Merged
@i-norden
Copy link
Collaborator Author

Satisfied in #43

@roysc roysc mentioned this issue Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roysc roysc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i-norden @roysc