Support the NVHPC compiler #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiler does not support the -fstack-protector-all flag, which is therefore removed from ReleaseDebugAutoFlags.cmake.
|
Hello, Thank you for your contribution! Cheers, |
|
Just to add to my previous comment. This change would allow starting the compilation process with NVHPC compiler, but there's no guarantee it would work all the way to the end. Probably future problems will be discovered. |
Right. We have found some issues with NVHPC when compiling the LLVM inside ROOT, but this has been reported to NVIDIA and a newer compiler version may solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was trying to build ROOT with Nvidia's NVHPC compiler. I got stuck quite soon because your library specifies the flag
-fstack-protector-all, which is not known to this compiler. This PR therefore creates an additional config in ReleaseDebugAutoFlags.cmake, similar to your exception for MSVC, where this flag is removed.