Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove console calls in treeparser #209

Closed
Tracked by #228
lcottercertinia opened this issue Jan 4, 2023 · 0 comments · Fixed by #443
Closed
Tracked by #228

refactor: remove console calls in treeparser #209

lcottercertinia opened this issue Jan 4, 2023 · 0 comments · Fixed by #443
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lcottercertinia
Copy link
Collaborator

Unknown and bad log lines are printed in the console, users do not really check this.
We should come up with a better way of notifying the user about these lines.

We should probably return the lines as part of the root node as "invalid lines"

  1. Then send them to the vscode output channel or
  2. List them somewhere in the log-viewer ui
  3. It might also be ideal for these to be sent back to us or allow the user to easily report them back to us so we can improve the parser.
@lcottercertinia lcottercertinia added the enhancement New feature or request label Jan 4, 2023
@lcottercertinia lcottercertinia added this to the v1.12.0 milestone Oct 19, 2023
@lcottercertinia lcottercertinia self-assigned this Nov 11, 2023
This was referenced Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant