Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot expert #1048

Closed
ghost opened this issue Jul 25, 2017 · 5 comments
Closed

Screenshot expert #1048

ghost opened this issue Jul 25, 2017 · 5 comments
Labels
architecture component: bots feature Indicates new feature requests or new features
Milestone

Comments

@ghost
Copy link

ghost commented Jul 25, 2017

Create screenshots of URLs.

Depends on some infrastructure for saving/serving screenshots, needs to be discussed first. First simple proposal:

  • save the file in a defined directory, filename is a generated UUID
  • a URL-prefix is defined in the parameters
  • screenshot_url is prefix + filename

Candidate for a screenshot module: python-webkit2png, not good maintained, thus requires a fork of it to merge all open PRs from there.

@ghost ghost added component: bots feature Indicates new feature requests or new features labels Jul 25, 2017
@ghost ghost modified the milestone: 1.2.0 Aug 9, 2017
@ghost ghost modified the milestones: 1.2.0, More bots and feeds Jun 21, 2018
@navtej
Copy link
Contributor

navtej commented Sep 5, 2018

What do you think of using headless chrome for it? I dont like the dependency on chrome though. However it will be much better solution.

@ghost
Copy link
Author

ghost commented Sep 5, 2018

We can't avoid a dependency. We can also have multiple supported browsers if that is necessary.

An argument for chrome/chromium is, that it is widespread - and the rendering shouldn't have surprises.

@aaronkaplan
Copy link
Member

We will need this for 3.0

@ghost
Copy link
Author

ghost commented Feb 27, 2021

In the last IHAP meeting lookyloo was mentioned as possible screenshotting service, although slow.

@ghost
Copy link
Author

ghost commented Jun 17, 2021

fixed by #1844

@ghost ghost closed this as completed Jun 17, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

No branches or pull requests

2 participants