Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make extract_atom, extract_global, and gather typestable #65

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Joroks
Copy link
Collaborator

@Joroks Joroks commented Sep 1, 2024

I managed to make extract_atom, extract_global, and gather typestable through constant propagation. These changes are unavoidably breaking, but I strongly believe that this is for the better.

I still have to update documentation and a few checks I probably also need to check that I haven't messed up anywhere but everything seems to be working at least.

I think we could also have a similar issue with cache invalidation as we have with BIGINT etc. But I'm not familiar enough with the internals of julia to know for sure.

I'd like to know your opinion on this @vchuravy
(P.s. I'm sorry for the large and messy PR)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.60305% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (b60ac24) to head (c3b1ff1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/LAMMPS.jl 91.60% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   73.12%   72.81%   -0.31%     
==========================================
  Files           2        2              
  Lines         480      493      +13     
==========================================
+ Hits          351      359       +8     
- Misses        129      134       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joroks Joroks marked this pull request as ready for review September 3, 2024 18:40
@Joroks Joroks requested a review from vchuravy September 3, 2024 18:40
@Joroks
Copy link
Collaborator Author

Joroks commented Sep 3, 2024

I had to use Symbols instead of Strings as the constant propagation didn't work otherwise. I decided to make this a universal change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants