make extract_atom, extract_global, and gather typestable #65
+246
−302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to make
extract_atom
,extract_global
, andgather
typestable through constant propagation. These changes are unavoidably breaking, but I strongly believe that this is for the better.I still have to update documentation and a few checks I probably also need to check that I haven't messed up anywhere but everything seems to be working at least.
I think we could also have a similar issue with cache invalidation as we have with BIGINT etc. But I'm not familiar enough with the internals of julia to know for sure.
I'd like to know your opinion on this @vchuravy
(P.s. I'm sorry for the large and messy PR)