Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #478, remove inconsistent wording about special characters #548

Open
Dave-Allured opened this issue Oct 9, 2024 · 2 comments · May be fixed by #549
Open

Revert #478, remove inconsistent wording about special characters #548

Dave-Allured opened this issue Oct 9, 2024 · 2 comments · May be fixed by #549
Labels
CF1.12? We might conclude this issue in time for CF1.12 enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format

Comments

@Dave-Allured
Copy link
Contributor

Dave-Allured commented Oct 9, 2024 •
edited
Loading

Moderator

TBD

Associated pull request

#549

Detailed Proposal

Revert PR #478. Remove this single line from section 2.3, Naming Conventions:
"ASCII period (.) and ASCII hyphen (-) are also allowed in attribute names only."

This line was based on my misunderstanding of an earlier version of 2.3 paragraph 1. That paragraph was later clarified by PR #526, which now says that character restrictions are a recommendation, not a requirement. Therefore this new sentence is redundant and confusing.
@Dave-Allured Dave-Allured added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Open
@JonathanGregory JonathanGregory mentioned this issue Oct 14, 2024
Open
@JonathanGregory
Copy link
Contributor

Dear @Dave-Allured

Thanks for raising this issue. It is relevant to #528 and discussion 323, so I've flagged it in both. Since the proposal to add this sentence was accepted as an enhancement, with the required amount of support being expressed, I don't think we can reverse that decision as a defect i.e. if no-one objects. I think we need support for your proposal to remove the sentence as a new enhancement, so I'll change the label.

Best wishes

Jonathan

@JonathanGregory JonathanGregory added enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format and removed defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors labels Oct 14, 2024
@Dave-Allured
Copy link
Contributor Author

@JonathanGregory, thanks for switching the label. That is fine with me.

@JonathanGregory JonathanGregory added the CF1.12? We might conclude this issue in time for CF1.12 label Oct 20, 2024
@JonathanGregory JonathanGregory linked a pull request Oct 20, 2024 that will close this issue
ch02: Revert PR 478, period and hyphen in names #549
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CF1.12? We might conclude this issue in time for CF1.12 enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ch02: Revert PR 478, period and hyphen in names Dave-Allured/cf-conventions
2 participants
@JonathanGregory @Dave-Allured