From c46c3be250466b35535ab5e26c01634cd4847383 Mon Sep 17 00:00:00 2001
From: Jamey Sharp <jsharp@fastly.com>
Date: Mon, 18 Sep 2023 16:26:30 -0700
Subject: [PATCH] Implement some CacheIR guards

There is one jit-test which fails if the `GuardIsNumber` test is
implemented backward, and there are 22 jit-tests which fail if
`GuardBooleanToInt32` swaps "true" and "false" results, so I'm
reasonably confident this implementation of these CacheIR ops is correct
and adequately tested.
---
 js/src/vm/PortableBaselineInterpret.cpp | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/js/src/vm/PortableBaselineInterpret.cpp b/js/src/vm/PortableBaselineInterpret.cpp
index 1bdbbc49e7f16..9b5279e7ce3b3 100644
--- a/js/src/vm/PortableBaselineInterpret.cpp
+++ b/js/src/vm/PortableBaselineInterpret.cpp
@@ -496,6 +496,26 @@ ICInterpretOps(BaselineFrame* frame, VMFrameManager& frameMgr, State& state,
     DISPATCH_CACHEOP();
   }
 
+  CACHEOP_CASE(GuardIsNumber) {
+    ValOperandId inputId = icregs.cacheIRReader.valOperandId();
+    Value v = Value::fromRawBits(icregs.icVals[inputId.id()]);
+    if (!v.isNumber()) {
+      return ICInterpretOpResult::NextIC;
+    }
+    DISPATCH_CACHEOP();
+  }
+
+  CACHEOP_CASE(GuardBooleanToInt32) {
+    ValOperandId inputId = icregs.cacheIRReader.valOperandId();
+    Int32OperandId resultId = icregs.cacheIRReader.int32OperandId();
+    Value v = Value::fromRawBits(icregs.icVals[inputId.id()]);
+    if (!v.isBoolean()) {
+      return ICInterpretOpResult::NextIC;
+    }
+    icregs.icVals[resultId.id()] = v.toBoolean() ? 1 : 0;
+    DISPATCH_CACHEOP();
+  }
+
   CACHEOP_CASE(GuardToBoolean) {
     ValOperandId inputId = icregs.cacheIRReader.valOperandId();
     Value v = Value::fromRawBits(icregs.icVals[inputId.id()]);
@@ -1614,7 +1634,7 @@ ICInterpretOps(BaselineFrame* frame, VMFrameManager& frameMgr, State& state,
     DISPATCH_CACHEOP();
   }
 
-  CACHEOP_CASE_UNIMPL(GuardNoAllocationMetadataBuilder) {
+  CACHEOP_CASE(GuardNoAllocationMetadataBuilder) {
     uint32_t builderAddrOffset = icregs.cacheIRReader.stubOffset();
     uintptr_t builderAddr =
         cstub->stubInfo()->getStubRawWord(cstub, builderAddrOffset);
@@ -1624,9 +1644,7 @@ ICInterpretOps(BaselineFrame* frame, VMFrameManager& frameMgr, State& state,
     DISPATCH_CACHEOP();
   }
 
-  CACHEOP_CASE_UNIMPL(GuardIsNumber)
   CACHEOP_CASE_UNIMPL(GuardToNonGCThing)
-  CACHEOP_CASE_UNIMPL(GuardBooleanToInt32)
   CACHEOP_CASE_UNIMPL(Int32ToIntPtr)
   CACHEOP_CASE_UNIMPL(GuardNumberToIntPtrIndex)
   CACHEOP_CASE_UNIMPL(GuardToInt32ModUint32)