Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Tables documentation page: table pagination display is broken #617

Open
marteki opened this issue Nov 6, 2018 · 3 comments
Open

Tables documentation page: table pagination display is broken #617

marteki opened this issue Nov 6, 2018 · 3 comments
Labels

Comments

@marteki
Copy link
Member

marteki commented Nov 6, 2018

On the documentation page for Tables, the table pagination example doesn't appear properly: the "Newer" and "Older" buttons don't scale, and they instead overlap the "Page" label and the "Go" button.

I think this is less a problem with the actual pagination component, and more an issue with the way the Design Manual page is laid out. I believe that the wider desktop view of the table is being shown because the whole page is wider, even though the table only fills up a column on the page. Is there a way we could show the table pagination more as it's intended to be seen on a production web page?

screen shot 2018-11-06 at 11 23 51 am

@cfarm
Copy link
Contributor

cfarm commented Jan 23, 2019

do you have an example of this in production?

@anselmbradford
Copy link
Member

The only filterable table I know of is https://www.consumerfinance.gov/activity-log/, which does not have this issue.

@jimmynotjim
Copy link
Contributor

I think this is less a problem with the actual pagination component, and more an issue with the way the Design Manual page is laid out

Yep, you're right on the money. Only solution I have found is to put the table inside an iframe (this is what storybook does).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants