Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

List and group reports #133

Closed
awolfe76 opened this issue May 9, 2018 · 3 comments
Closed

List and group reports #133

awolfe76 opened this issue May 9, 2018 · 3 comments
Assignees

Comments

@awolfe76
Copy link
Contributor

awolfe76 commented May 9, 2018

From #57

Since there will always be the same reports for every MSA/MD, I don't think we need a dropdown. We can list them all, and have each link to a new tab or browser window, so if someone wants to view multiple reports at a time they can.

@awolfe76 awolfe76 added the A&D label May 9, 2018
@wpears
Copy link
Member

wpears commented May 10, 2018

I'm not strictly against this, but I don't know if we need it, or rather I'd like to talk more about the justification. Is it just that links are simpler/easier to grok?

@awolfe76
Copy link
Contributor Author

I agree I'm 50/50 on this one.

@designlanguage mentions being able to allow opening several reports at a time, each in a new tab/window. That seems nice, but I'm not sure if that's something we need.

I do also think it's easier to read in the format he proposes but maybe we could add something similar to HTML <optgroup label="label">. It looks like this is possible with react-select (see this issue). That might allow us to improve the readability of the choices with groupings while keeping the dropdown

Would that help?

@wpears
Copy link
Member

wpears commented May 10, 2018

Yeah I was thinking that would be a good middle ground as well.

@awolfe76 awolfe76 self-assigned this May 11, 2018
@awolfe76 awolfe76 mentioned this issue May 15, 2018
@wpears wpears closed this as completed May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants