Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Add GitHub Action workflows #383

Merged
merged 42 commits into from
Apr 20, 2020
Merged

Add GitHub Action workflows #383

merged 42 commits into from
Apr 20, 2020

Conversation

cwdavies
Copy link
Contributor

This adds GitHub Action workflows for frontend/backend and to clean up Action storage artifacts.

We use Actions storage to store coverage files from the frontend/backend test jobs to be consumed by the coverage jobs. This storage is limited to 500MB. Once the coverage jobs run there's no need to keep the coverage files around. This workflow will run every hour and remove all artifacts from completed jobs.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

We use Actions storage to store coverage files from the frontend/backend test jobs to be consumed by the coverage jobs. This storage is limited to 500MB. Once the coverage jobs run there's no need to keep the coverage files around. This workflow will run every hour and remove all artifacts from completed jobs.
@cwdavies cwdavies requested a review from a team April 14, 2020 19:11
@cwdavies cwdavies requested a review from a team April 14, 2020 23:18
Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider the level of complexity we actually need here rather than just importing the cfgov-refresh setup wholesale.

We could probably combine the frontend and backend and coverage into a single job, or a single workflow with multiple jobs, I think.

I also think we should also figure out why Travis is failing before we try to replace it.

tox.ini Outdated Show resolved Hide resolved
.github/workflows/artifact_cleanup.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's squash it and ship it!

@Scotchester Scotchester merged commit 4e163de into master Apr 20, 2020
@Scotchester Scotchester deleted the github-actions branch April 20, 2020 15:51
willbarton added a commit to cfpb/development that referenced this pull request Jun 19, 2020
This is an attempt to codify some common GitHub Actions recipes that we can use, probably with tweaks, across multiple repositories.

It is based in part on work that the Dev Services team did to add GitHub Actions to [teachers-digital-platform](cfpb/curriculum-review-tool#383) and previously to cfgov-refresh
willbarton added a commit to cfpb/development that referenced this pull request Jun 19, 2020
This is an attempt to codify some common GitHub Actions recipes that we can use, probably with tweaks, across multiple repositories.

It is based in part on work that the Dev Services team did to add GitHub Actions to [teachers-digital-platform](cfpb/curriculum-review-tool#383) and previously to cfgov-refresh
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants