From dbc5dcf07b1dbb10c724c83a48e7e41b394afb0d Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Mon, 2 Oct 2023 21:49:33 +0200
Subject: [PATCH 1/7] [qa] remove undefined store mutation

---
 src/App.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/App.vue b/src/App.vue
index 51f57448f7..f780b08582 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -358,7 +358,6 @@ export default {
       'person:delete'(eventData) {
         const person = this.personMap.get(eventData.person_id)
         if (person) {
-          this.$store.commit('DELETE_PEOPLE_START', person)
           this.$store.commit('DELETE_PEOPLE_END', person)
         }
       },

From a7b4e472d8cc0cfdcead231c6d2de919d7cd8f72 Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Mon, 2 Oct 2023 21:52:18 +0200
Subject: [PATCH 2/7] =?UTF-8?q?[qa]=C2=A0fix=20silent=20error=20on=20refre?=
 =?UTF-8?q?shMetadataDescriptor?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/App.vue | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index f780b08582..1e9b5085df 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -419,11 +419,15 @@ export default {
       },
 
       'metadata-descriptor:new'(eventData) {
-        this.refreshMetadataDescriptor(eventData.metadata_descriptor_id)
+        if (this.currentProduction?.id === eventData.project_id) {
+          this.refreshMetadataDescriptor(eventData.metadata_descriptor_id)
+        }
       },
 
       'metadata-descriptor:update'(eventData) {
-        this.refreshMetadataDescriptor(eventData.metadata_descriptor_id)
+        if (this.currentProduction?.id === eventData.project_id) {
+          this.refreshMetadataDescriptor(eventData.metadata_descriptor_id)
+        }
       },
 
       'metadata-descriptor:delete'(eventData) {

From 34ff97aab3b6e2cc84a44f5ead9a896067a08a20 Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Tue, 3 Oct 2023 09:34:37 +0200
Subject: [PATCH 3/7] [qa] refactor code

---
 src/App.vue                                     | 15 +++++----------
 src/components/mixins/search.js                 |  8 --------
 src/components/pages/Assets.vue                 |  8 +++++---
 src/components/pages/Profile.vue                |  1 -
 src/components/tops/Topbar.vue                  |  9 ++-------
 src/components/widgets/LightEntityThumbnail.vue |  5 +----
 src/store/api/people.js                         |  6 +++---
 src/store/modules/people.js                     |  1 -
 src/store/modules/productions.js                | 17 ++++++-----------
 src/store/modules/user.js                       |  4 ++--
 src/store/mutation-types.js                     |  3 ---
 11 files changed, 24 insertions(+), 53 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 1e9b5085df..71cce46825 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -166,8 +166,7 @@ export default {
       'sequence:new'(eventData) {
         if (
           !this.sequenceMap.get(eventData.sequence_id) &&
-          this.currentProduction &&
-          this.currentProduction.id === eventData.project_id
+          this.currentProduction?.id === eventData.project_id
         ) {
           this.loadSequence(eventData.sequence_id)
         }
@@ -188,8 +187,7 @@ export default {
       'edit:new'(eventData) {
         if (
           !this.editMap.get(eventData.edit_id) &&
-          this.currentProduction &&
-          this.currentProduction.id === eventData.project_id
+          this.currentProduction?.id === eventData.project_id
         ) {
           this.loadEdit(eventData.edit_id)
         }
@@ -210,8 +208,7 @@ export default {
       'episode:new'(eventData) {
         if (
           !this.episodeMap.get(eventData.episode_id) &&
-          this.currentProduction &&
-          this.currentProduction.id === eventData.project_id
+          this.currentProduction?.id === eventData.project_id
         ) {
           this.loadEpisode(eventData.episode_id)
         }
@@ -232,8 +229,7 @@ export default {
       'shot:new'(eventData) {
         if (
           !this.shotMap.get(eventData.shot_id) &&
-          this.currentProduction &&
-          this.currentProduction.id === eventData.project_id &&
+          this.currentProduction?.id === eventData.project_id &&
           (!this.isTVShow || this.currentEpisode.id === eventData.episode_id)
         ) {
           setTimeout(() => {
@@ -257,8 +253,7 @@ export default {
       'asset:new'(eventData) {
         if (
           !this.assetMap.get(eventData.asset_id) &&
-          this.currentProduction &&
-          this.currentProduction.id === eventData.project_id
+          this.currentProduction?.id === eventData.project_id
         ) {
           setTimeout(() => {
             this.loadAsset(eventData.asset_id)
diff --git a/src/components/mixins/search.js b/src/components/mixins/search.js
index f74469735f..a2d720387c 100644
--- a/src/components/mixins/search.js
+++ b/src/components/mixins/search.js
@@ -3,14 +3,6 @@
  * list.
  */
 export const searchMixin = {
-  created() {},
-
-  mounted() {},
-
-  beforeDestroy() {},
-
-  computed: {},
-
   methods: {
     changeSearch(searchQuery) {
       this.searchField.setValue(searchQuery.search_query)
diff --git a/src/components/pages/Assets.vue b/src/components/pages/Assets.vue
index e40affa0bc..4f361df143 100644
--- a/src/components/pages/Assets.vue
+++ b/src/components/pages/Assets.vue
@@ -680,15 +680,16 @@ export default {
       this.loading.deleteAllTasks = true
       this.deleteAllAssetTasks({ projectId, taskTypeId, selectionOnly })
         .then(() => {
-          this.loading.deleteAllTasks = false
           if (!selectionOnly) this.loadAssets()
           this.modals.isDeleteAllTasksDisplayed = false
         })
         .catch(err => {
           console.error(err)
-          this.loading.deleteAllTasks = false
           this.errors.deleteAllTasks = true
         })
+        .finally(() => {
+          this.loading.deleteAllTasks = false
+        })
     },
 
     confirmDeleteMetadata() {
@@ -697,12 +698,13 @@ export default {
       this.deleteMetadataDescriptor(this.descriptorIdToDelete)
         .then(() => {
           this.errors.deleteMetadata = false
-          this.loading.deleteMetadata = false
           this.modals.isDeleteMetadataDisplayed = false
         })
         .catch(err => {
           console.error(err)
           this.errors.deleteMetadata = true
+        })
+        .finally(() => {
           this.loading.deleteMetadata = false
         })
     },
diff --git a/src/components/pages/Profile.vue b/src/components/pages/Profile.vue
index d3402c3ec6..5bbc1a60b5 100644
--- a/src/components/pages/Profile.vue
+++ b/src/components/pages/Profile.vue
@@ -288,7 +288,6 @@
           />
           <textarea
             class="input recovery-codes"
-            ref="textField"
             v-text="twoFA.OTPRecoveryCodes.join('\t')"
             readonly
           ></textarea>
diff --git a/src/components/tops/Topbar.vue b/src/components/tops/Topbar.vue
index 6d979d4385..aee8030ed7 100644
--- a/src/components/tops/Topbar.vue
+++ b/src/components/tops/Topbar.vue
@@ -112,12 +112,8 @@
           </a>
         </div>
         <div
-          :class="{
-            'nav-item': true,
-            'user-nav': true,
-            active: !isUserMenuHidden
-          }"
-          ref="user-name"
+          class="nav-item user-nav"
+          :class="{ active: !isUserMenuHidden }"
           @click="toggleUserMenu"
         >
           <people-avatar
@@ -132,7 +128,6 @@
 
     <nav
       class="user-menu"
-      ref="user-menu"
       :style="{
         top: isUserMenuHidden ? '-480px' : '60px'
       }"
diff --git a/src/components/widgets/LightEntityThumbnail.vue b/src/components/widgets/LightEntityThumbnail.vue
index 4442603761..30b6e78d74 100644
--- a/src/components/widgets/LightEntityThumbnail.vue
+++ b/src/components/widgets/LightEntityThumbnail.vue
@@ -14,10 +14,7 @@
     v-if="props.previewFileId"
   />
   <span
-    :class="{
-      'thumbnail-picture': true,
-      'thumbnail-empty': true
-    }"
+    class="thumbnail-picture thumbnail-empty"
     :style="{
       width: props.width,
       height: props.emptyHeight ? props.emptyHeight : props.height
diff --git a/src/store/api/people.js b/src/store/api/people.js
index 0817917ae7..c5119a8ee9 100644
--- a/src/store/api/people.js
+++ b/src/store/api/people.js
@@ -95,7 +95,7 @@ export default {
     return client.pput(`/api/data/persons/${person.id}`, data)
   },
 
-  deletePerson(person, callback) {
+  deletePerson(person) {
     return client.pdel(`/api/data/persons/${person.id}?force=true`)
   },
 
@@ -105,14 +105,14 @@ export default {
       password_2: form.password2
     }
     return client.ppost(
-      `api/actions/persons/${person.id}/change-password`,
+      `/api/actions/persons/${person.id}/change-password`,
       data
     )
   },
 
   disableTwoFactorAuthenticationPerson(person) {
     return client.pdel(
-      `api/actions/persons/${person.id}/disable-two-factor-authentication`
+      `/api/actions/persons/${person.id}/disable-two-factor-authentication`
     )
   },
 
diff --git a/src/store/modules/people.js b/src/store/modules/people.js
index f99fa06e17..f4acbd635d 100644
--- a/src/store/modules/people.js
+++ b/src/store/modules/people.js
@@ -274,7 +274,6 @@ const actions = {
   newPerson({ commit, state }, data) {
     return peopleApi.createPerson(data).then(person => {
       commit(EDIT_PEOPLE_END, person)
-      Promise.resolve()
     })
   },
 
diff --git a/src/store/modules/productions.js b/src/store/modules/productions.js
index a62e72e378..d9f750dcc2 100644
--- a/src/store/modules/productions.js
+++ b/src/store/modules/productions.js
@@ -335,7 +335,7 @@ const actions = {
     commit(EDIT_PRODUCTION_START, data)
     return productionsApi.newProduction(data).then(production => {
       commit(EDIT_PRODUCTION_END, production)
-      return Promise.resolve(production)
+      return production
     })
   },
 
@@ -491,15 +491,11 @@ const actions = {
   },
 
   deleteMetadataDescriptor({ commit, state }, descriptorId) {
-    return new Promise((resolve, reject) => {
-      return productionsApi
-        .deleteMetadataDescriptor(state.currentProduction.id, descriptorId)
-        .then(() => {
-          commit(DELETE_METADATA_DESCRIPTOR_END, { id: descriptorId })
-          resolve()
-        })
-        .catch(reject)
-    })
+    return productionsApi
+      .deleteMetadataDescriptor(state.currentProduction.id, descriptorId)
+      .then(() => {
+        commit(DELETE_METADATA_DESCRIPTOR_END, { id: descriptorId })
+      })
   },
 
   refreshMetadataDescriptor({ commit, state }, descriptorId) {
@@ -524,7 +520,6 @@ const actions = {
             descriptor
           })
         }
-        return Promise.resolve()
       })
   }
 }
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index e0e712c175..49fd8f00c7 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -419,11 +419,11 @@ const mutations = {
     state.user = peopleStore.helpers.addAdditionalInformation(user)
     state.isAuthenticated = true
   },
-  [USER_LOGOUT](state, user) {
+  [USER_LOGOUT](state) {
     state.user = null
     state.isAuthenticated = false
   },
-  [USER_LOGIN_FAIL](state, user) {
+  [USER_LOGIN_FAIL](state) {
     state.user = null
     state.isAuthenticated = false
   },
diff --git a/src/store/mutation-types.js b/src/store/mutation-types.js
index f0cfed8c97..99a1d6a0aa 100644
--- a/src/store/mutation-types.js
+++ b/src/store/mutation-types.js
@@ -24,9 +24,6 @@ export const IMPORT_PEOPLE_END = 'IMPORT_PEOPLE_END'
 export const IMPORT_PEOPLE_ERROR = 'IMPORT_PEOPLE_ERROR'
 
 export const DELETE_PEOPLE_END = 'DELETE_PEOPLE_END'
-export const DELETE_PEOPLE_ERROR = 'DELETE_PEOPLE_ERROR'
-export const SHOW_DELETE_PEOPLE_MODAL = 'SHOW_DELETE_PEOPLE_MODAL'
-export const HIDE_DELETE_PEOPLE_MODAL = 'HIDE_DELETE_PEOPLE_MODAL'
 
 export const EDIT_PEOPLE_START = 'EDIT_PEOPLE_START'
 export const EDIT_PEOPLE_END = 'EDIT_PEOPLE_END'

From 59202e8cf0908d96568d3eed76e2dcfb94f9c285 Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Thu, 5 Oct 2023 10:58:17 +0200
Subject: [PATCH 4/7] [qa] fix silent error on playlist when toggling list

---
 src/components/pages/Playlist.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/pages/Playlist.vue b/src/components/pages/Playlist.vue
index 37466dcd46..47fb6fccb2 100644
--- a/src/components/pages/Playlist.vue
+++ b/src/components/pages/Playlist.vue
@@ -1348,7 +1348,7 @@ export default {
     },
 
     isListToggled() {
-      this.playlistPlayer.onWindowResize()
+      this.playlistPlayer?.onWindowResize()
     },
 
     taskTypeId() {

From b546e331a9cf14f7d11fe0cafe210942d97beef6 Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Thu, 5 Oct 2023 11:14:02 +0200
Subject: [PATCH 5/7] [qa] refactor SearchField widget with v-model

---
 src/components/widgets/SearchField.vue | 53 +++++++++-----------------
 1 file changed, 19 insertions(+), 34 deletions(-)

diff --git a/src/components/widgets/SearchField.vue b/src/components/widgets/SearchField.vue
index eb959c45fc..2db6e432d2 100644
--- a/src/components/widgets/SearchField.vue
+++ b/src/components/widgets/SearchField.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="flexrow search-field-wrapper" ref="wrapper" @click="focus">
+  <div class="flexrow search-field-wrapper" :class="{ focused }" @click="focus">
     <div class="flexrow-item">
       <search-icon class="search-icon" />
     </div>
@@ -12,8 +12,9 @@
         :placeholder="placeholder"
         @input="onSearchChange"
         @keyup.enter="onEnterPressed"
-        @focus="setFocusedStyle"
-        @blur="unsetFocusedStyle"
+        @focus="focused = true"
+        @blur="focused = false"
+        v-model.trim="search"
         v-focus="focusOptions"
       />
     </div>
@@ -37,7 +38,10 @@ export default {
   name: 'search-field',
 
   data() {
-    return {}
+    return {
+      search: '',
+      focused: false
+    }
   },
 
   props: {
@@ -49,6 +53,7 @@ export default {
       type: Boolean,
       default: false
     },
+    // FIXME:property no longer used in component
     active: {
       type: Boolean,
       default: true
@@ -63,53 +68,36 @@ export default {
     SearchIcon
   },
 
-  computed: {},
-
   methods: {
     onSearchChange() {
-      this.$emit('change', this.$refs.input.value)
+      this.$emit('change', this.search)
     },
 
     onEnterPressed() {
-      this.$emit('enter', this.$refs.input.value)
+      this.$emit('enter', this.search)
     },
 
     onSaveClicked() {
-      const value = this.$refs.input.value.trim()
-      if (value.length > 0) {
-        if (this.canSave) this.$emit('save', value)
+      if (this.search && this.canSave) {
+        this.$emit('save', this.search)
       }
     },
 
     getValue() {
-      if (this.$refs.input) {
-        return this.$refs.input.value
-      } else {
-        return ''
-      }
+      return this.search
     },
 
     setValue(value) {
-      this.$refs.input.value = value
+      this.search = value
     },
 
     focus(options) {
-      if (this.$refs.input) {
-        this.$refs.input.focus(options)
-      }
+      this.$refs.input?.focus(options)
     },
 
     clearSearch() {
-      this.setValue('')
+      this.search = ''
       this.onSearchChange()
-    },
-
-    setFocusedStyle() {
-      this.$refs.wrapper.className = 'flexrow search-field-wrapper focused'
-    },
-
-    unsetFocusedStyle() {
-      this.$refs.wrapper.className = 'flexrow search-field-wrapper'
     }
   }
 }
@@ -151,6 +139,8 @@ export default {
 }
 
 .search-icon {
+  width: 20px;
+  margin-top: 5px;
   color: var(--text);
 }
 
@@ -197,11 +187,6 @@ export default {
   border-color: $green;
 }
 
-.search-icon {
-  width: 20px;
-  margin-top: 5px;
-}
-
 @media screen and (max-width: 768px) {
   .search-input {
     width: 200px;

From ef143524c70f502884372a42f70147b73b16d2de Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Fri, 6 Oct 2023 10:47:25 +0200
Subject: [PATCH 6/7] [qa] bump dependencies

---
 package-lock.json | 61 ++++++++++++++++++++++-------------------------
 package.json      |  4 ++--
 2 files changed, 31 insertions(+), 34 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 3ab2ad6b2c..e2dd0957f9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -66,8 +66,8 @@
         "localStorage": "1.0.4",
         "postcss": "8.4.31",
         "prettier": "3.0.3",
-        "sass": "1.68.0",
-        "vite": "4.4.9",
+        "sass": "1.69.0",
+        "vite": "4.4.11",
         "vite-plugin-eslint": "1.8.1",
         "vitest": "0.34.6",
         "vitest-localstorage-mock": "0.0.1",
@@ -562,9 +562,9 @@
       }
     },
     "node_modules/@eslint-community/regexpp": {
-      "version": "4.9.0",
-      "resolved": "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.9.0.tgz",
-      "integrity": "sha512-zJmuCWj2VLBt4c25CfBIbMZLGLyhkvs7LznyVX5HfpzeocThgIj5XQK4L+g3U36mMcx8bPMhGyPpwCATamC4jQ==",
+      "version": "4.9.1",
+      "resolved": "https://registry.npmjs.org/@eslint-community/regexpp/-/regexpp-4.9.1.tgz",
+      "integrity": "sha512-Y27x+MBLjXa+0JWDhykM3+JE+il3kHKAEqabfEWq3SDhZjLYb6/BHL/JKFnH3fe207JaXkyDo685Oc2Glt6ifA==",
       "dev": true,
       "engines": {
         "node": "^12.0.0 || ^14.0.0 || >=16.0.0"
@@ -831,9 +831,9 @@
       "dev": true
     },
     "node_modules/@types/node": {
-      "version": "20.8.0",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.8.0.tgz",
-      "integrity": "sha512-LzcWltT83s1bthcvjBmiBvGJiiUe84NWRHkw+ZV6Fr41z2FbIzvc815dk2nQ3RAKMuN2fkenM/z3Xv2QzEpYxQ==",
+      "version": "20.8.2",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.8.2.tgz",
+      "integrity": "sha512-Vvycsc9FQdwhxE3y3DzeIxuEJbWGDsnrxvMADzTDF/lcdR9/K+AQIeAghTQsHtotg/q0j3WEOYS/jQgSdWue3w==",
       "dev": true
     },
     "node_modules/@types/trusted-types": {
@@ -1416,9 +1416,9 @@
       }
     },
     "node_modules/caniuse-lite": {
-      "version": "1.0.30001542",
-      "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001542.tgz",
-      "integrity": "sha512-UrtAXVcj1mvPBFQ4sKd38daP8dEcXXr5sQe6QNNinaPd0iA/cxg9/l3VrSdL73jgw5sKyuQ6jNgiKO12W3SsVA==",
+      "version": "1.0.30001546",
+      "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001546.tgz",
+      "integrity": "sha512-zvtSJwuQFpewSyRrI3AsftF6rM0X80mZkChIt1spBGEvRglCrjTniXvinc8JKRoqTwXAgvqTImaN9igfSMtUBw==",
       "dev": true,
       "funding": [
         {
@@ -2129,9 +2129,9 @@
       }
     },
     "node_modules/electron-to-chromium": {
-      "version": "1.4.537",
-      "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.537.tgz",
-      "integrity": "sha512-W1+g9qs9hviII0HAwOdehGYkr+zt7KKdmCcJcjH0mYg6oL8+ioT3Skjmt7BLoAQqXhjf40AXd+HlR4oAWMlXjA==",
+      "version": "1.4.543",
+      "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.543.tgz",
+      "integrity": "sha512-t2ZP4AcGE0iKCCQCBx/K2426crYdxD3YU6l0uK2EO3FZH0pbC4pFz/sZm2ruZsND6hQBTcDWWlo/MLpiOdif5g==",
       "dev": true
     },
     "node_modules/emoji-regex": {
@@ -3086,9 +3086,9 @@
       }
     },
     "node_modules/globals": {
-      "version": "13.22.0",
-      "resolved": "https://registry.npmjs.org/globals/-/globals-13.22.0.tgz",
-      "integrity": "sha512-H1Ddc/PbZHTDVJSnj8kWptIRSD6AM3pK+mKytuIVF4uoBV7rshFlhhvA58ceJ5wp3Er58w6zj7bykMpYXt3ETw==",
+      "version": "13.23.0",
+      "resolved": "https://registry.npmjs.org/globals/-/globals-13.23.0.tgz",
+      "integrity": "sha512-XAmF0RjlrjY23MA51q3HltdlGxUpXPvg0GioKiD9X6HD28iMjo2dKC8Vqwm7lne4GNr78+RHTfliktR6ZH09wA==",
       "dependencies": {
         "type-fest": "^0.20.2"
       },
@@ -3117,12 +3117,9 @@
       "dev": true
     },
     "node_modules/has": {
-      "version": "1.0.3",
-      "resolved": "https://registry.npmjs.org/has/-/has-1.0.3.tgz",
-      "integrity": "sha512-f2dvO0VU6Oej7RkWJGrehjbzMAjFp5/VKPp5tTpWIV4JHHZK1/BxbFRtf/siA2SWTe09caDmVtYYzWEIbBS4zw==",
-      "dependencies": {
-        "function-bind": "^1.1.1"
-      },
+      "version": "1.0.4",
+      "resolved": "https://registry.npmjs.org/has/-/has-1.0.4.tgz",
+      "integrity": "sha512-qdSAmqLF6209RFj4VVItywPMbm3vWylknmB3nvNiUIs72xAimcM8nVYxYr7ncvZq5qzk9MKIZR8ijqD/1QuYjQ==",
       "engines": {
         "node": ">= 0.4.0"
       }
@@ -5162,9 +5159,9 @@
       }
     },
     "node_modules/sass": {
-      "version": "1.68.0",
-      "resolved": "https://registry.npmjs.org/sass/-/sass-1.68.0.tgz",
-      "integrity": "sha512-Lmj9lM/fef0nQswm1J2HJcEsBUba4wgNx2fea6yJHODREoMFnwRpZydBnX/RjyXw2REIwdkbqE4hrTo4qfDBUA==",
+      "version": "1.69.0",
+      "resolved": "https://registry.npmjs.org/sass/-/sass-1.69.0.tgz",
+      "integrity": "sha512-l3bbFpfTOGgQZCLU/gvm1lbsQ5mC/WnLz3djL2v4WCJBDrWm58PO+jgngcGRNnKUh6wSsdm50YaovTqskZ0xDQ==",
       "dev": true,
       "dependencies": {
         "chokidar": ">=3.0.0 <4.0.0",
@@ -5689,9 +5686,9 @@
       }
     },
     "node_modules/tinyspy": {
-      "version": "2.1.1",
-      "resolved": "https://registry.npmjs.org/tinyspy/-/tinyspy-2.1.1.tgz",
-      "integrity": "sha512-XPJL2uSzcOyBMky6OFrusqWlzfFrXtE0hPuMgW8A2HmaqrPo4ZQHRN/V0QXN3FSjKxpsbRrFc5LI7KOwBsT1/w==",
+      "version": "2.2.0",
+      "resolved": "https://registry.npmjs.org/tinyspy/-/tinyspy-2.2.0.tgz",
+      "integrity": "sha512-d2eda04AN/cPOR89F7Xv5bK/jrQEhmcLFe6HFldoeO9AJtps+fqEnh486vnT/8y4bw38pSyxDcTCAq+Ks2aJTg==",
       "dev": true,
       "engines": {
         "node": ">=14.0.0"
@@ -5886,9 +5883,9 @@
       "integrity": "sha512-ocyWc3bAHBB/guyqJQVI5o4BZkPhznPYUG2ea80Gond/BgNWpap8TOmLSeeQG7bnh2KMISxskdADG59j7zruhw=="
     },
     "node_modules/vite": {
-      "version": "4.4.9",
-      "resolved": "https://registry.npmjs.org/vite/-/vite-4.4.9.tgz",
-      "integrity": "sha512-2mbUn2LlUmNASWwSCNSJ/EG2HuSRTnVNaydp6vMCm5VIqJsjMfbIWtbH2kDuwUVW5mMUKKZvGPX/rqeqVvv1XA==",
+      "version": "4.4.11",
+      "resolved": "https://registry.npmjs.org/vite/-/vite-4.4.11.tgz",
+      "integrity": "sha512-ksNZJlkcU9b0lBwAGZGGaZHCMqHsc8OpgtoYhsQ4/I2v5cnpmmmqe5pM4nv/4Hn6G/2GhTdj0DhZh2e+Er1q5A==",
       "dev": true,
       "dependencies": {
         "esbuild": "^0.18.10",
diff --git a/package.json b/package.json
index 5f14e44baf..de50e8c135 100644
--- a/package.json
+++ b/package.json
@@ -73,8 +73,8 @@
     "localStorage": "1.0.4",
     "postcss": "8.4.31",
     "prettier": "3.0.3",
-    "sass": "1.68.0",
-    "vite": "4.4.9",
+    "sass": "1.69.0",
+    "vite": "4.4.11",
     "vite-plugin-eslint": "1.8.1",
     "vitest": "0.34.6",
     "vitest-localstorage-mock": "0.0.1",

From 5e81414d49b05fefd5baf196fe269a0fa28a8c43 Mon Sep 17 00:00:00 2001
From: Nicolas Pennec <nicolas.pennec@cg-wire.com>
Date: Fri, 6 Oct 2023 14:22:03 +0200
Subject: [PATCH 7/7] [previews] fix tile preloading

---
 src/components/previews/PreviewPlayer.vue | 2 +-
 src/components/previews/VideoProgress.vue | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/previews/PreviewPlayer.vue b/src/components/previews/PreviewPlayer.vue
index 90be7abade..fcb1b80275 100644
--- a/src/components/previews/PreviewPlayer.vue
+++ b/src/components/previews/PreviewPlayer.vue
@@ -114,7 +114,7 @@
         :width="width"
         :handle-in="-1"
         :handle-out="-1"
-        :preview-id="currentPreview ? currentPreview.id : ''"
+        :preview-id="isMovie && currentPreview ? currentPreview.id : ''"
         @start-scrub="$refs['button-bar'].classList.add('unselectable')"
         @end-scrub="$refs['button-bar'].classList.remove('unselectable')"
         @progress-changed="onProgressChanged"
diff --git a/src/components/previews/VideoProgress.vue b/src/components/previews/VideoProgress.vue
index b9b1d1f233..a39743cda1 100644
--- a/src/components/previews/VideoProgress.vue
+++ b/src/components/previews/VideoProgress.vue
@@ -385,7 +385,7 @@ export default {
     },
 
     previewId() {
-      if (this.movieDimensions.width) {
+      if (this.movieDimensions.width && this.previewId) {
         const path = `/api/movies/tiles/preview-files/${this.previewId}.png`
         const img = new Image()
         this.isTileLoading = true