Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It'd be awesome if we could give the spandrel a facelift with some new functionality. :) #152

Closed
zelenooki87 opened this issue Feb 14, 2024 · 7 comments
Labels
Arch request Request to add support for an architecture

Comments

@zelenooki87
Copy link

following architectures:

FFTFormer:
https://github.com/kkkls/fftformer
M3SNet:
https://github.com/Tombs98/M3SNet
MHNet:
https://github.com/Tombs98/MHNet
Maxim:
https://github.com/vztu/maxim-pytorch/tree/main
And:
Restormer:
https://github.com/swz30/restormer
(because, KBNet and Nafnet do not work properly for some images - I opened a bug issue about this)

@joeyballentine joeyballentine transferred this issue from chaiNNer-org/chaiNNer Feb 14, 2024
@RunDevelopment
Copy link
Member

I added support for Restormer (#170), FFTFormer (#171), and M3SNet (#172). The other 2 are weird:

  • The official Maxim implementation uses a different framework that isn't compatible with PyTorch. You linked a PyTorch re-implementation of Maxim.
  • MHNet is a mess. The author deleted the arch code (it's still accessible via git history) and there are no pretrained models. The paper makes it out to be an amazing arch, so I wonder why the repo has these problems. Anyway, I already put together the arch code, but it's useless without pretrained models to test it. Without pretrained models, I cannot add MHNet.

@RunDevelopment RunDevelopment added the Arch request Request to add support for an architecture label Feb 22, 2024
@zelenooki87
Copy link
Author

Thank you very much, friend! I saw them in benchmark tests on the paperswithcode website, so I thought they would be okay. I haven't tested them all. Thank you very much again!

@zelenooki87
Copy link
Author

zelenooki87 commented Mar 7, 2024

Is it possible to add support for RESTORMER's gaussian_color_denoising_blind.pth model? ( https://drive.google.com/drive/folders/1Qwsjyny54RZWa7zC4Apg7exixLBo4uF0 ) Chaninner not supports it.
Other restormer models that I have tested working okay.

Thank you again.

@RunDevelopment
Copy link
Member

Chaninner not supports it.

Because we haven't updated spandrel yet. Chainner currently doesn't support any of the above architectures, but it will in a few days :)

Other restormer models that I have tested working okay.

How...

@zelenooki87
Copy link
Author

I apologize, my mistake! Up until recently, it was working with custom builds. I would periodically update it by manually copying files from the source folder. Unfortunately, that's practically impossible now. Thanks for the info, I'll wait for it to be fixed.

By the way, about the white balance we discussed in another thread (if you haven't seen it yet), is there a chance we can integrate that as well?

@RunDevelopment
Copy link
Member

By the way, about the white balance we discussed in another thread (if you haven't seen it yet), is there a chance we can integrate that as well?

It's not rejected, but nobody is currently working on it. It's a relatively low-prio item, so it might take some time until we implement it.

@RunDevelopment
Copy link
Member

I'm going to close this issue now.

I'm unsure about the PyTorch reimplementation of Maxim. It might be useful, but it feels a little weird to add it. Please make a separate issue if the architecture is dearly wanted.

MHNet is rejected due to problems with the repo (author deleted arch code, no pretrained models). If those problems are somehow resolved in the future, we can add it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch request Request to add support for an architecture
Projects
None yet
Development

No branches or pull requests

2 participants