Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trained models #551

Closed
prabhatnagarajan opened this issue Sep 8, 2019 · 2 comments · Fixed by #608
Closed

Add trained models #551

prabhatnagarajan opened this issue Sep 8, 2019 · 2 comments · Fixed by #608
Assignees

Comments

@prabhatnagarajan
Copy link
Contributor

  • Add an example where a user can load a trained model.
@Pit-Storm
Copy link

There are trained Models now, but one is not able to download it. If I run the reproduction example for A3C with pretrained model demo, I got a HTTP Error "403: Forbidden" for the URL https://chainer-assets.preferred.jp/chainerrl/A3C/Breakout\final.zip

I think this is a convenience with joining paths. Are you joining the URL-Path with os.path.join?
When it's coming to on-disk-paths python can handle \ or / in whatever OS it is. On windows os.path.join joins with \ and on unix systems it joins with /. When you join a URL on windows it joins a \ instead a /.

When i replace the \ (right before final.zip in the upper URL) with an / I can access the file manually.

Maybe you can fix it in your code?

@prabhatnagarajan
Copy link
Contributor Author

You're correct that we use join: https://github.com/chainer/chainerrl/blob/master/chainerrl/misc/pretrained_models.py#L124
cache_path = cached_download(os.path.join(url_basepath,file))
Where file is final.zip.

Thanks for sharing! I'll try and amend this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants