-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error "'solid-js/web' does not provide an export named 'memo'" #1363
Comments
I am also getting this error. Rolling back to 0.9 in my dependencies fixed the issue for now. |
@alexvuka1 Were you able to figure this out? |
Thanks for taking your time to report this issue. I'm not 100% sure about solid and this hybrid server / client stuff but I think there are ways to exclude @ark-ui/solid I have a running solid app for Park UI here https://stackblitz.com/github/cschroeter/park-ui/tree/main/examples/solid/vite?file=src/examples/authentication-card.tsx |
Can confirm manually building and exporting the lib with the generate ssr config resolved the issue for me, not sure what's the implications. If there are indeed issues with the ssr build when using in spa, maybe 2 builds with conditional exports could help. |
Setting A simple story like
will not render any output. I can try to use |
After spending 1-2h on that topic I somewhat understand the issue. I'm happy to add conditional export like "./carousel": {
"types": "./carousel/index.d.ts",
"node": "./dist/server/index.server.mjs",
"import": "./carousel/index.mjs",
"require": "./carousel/index.cjs"
}, But apparently that is not enough since Solid Start apparently also requires an additional https://github.com/solidjs-community/tsup-preset-solid#usage-gotchas Since this is not documented on their official website or the SolidStart project, we will wait until we add support for this. Thanks for your understanding. |
As a newcomer to Solid and Ark, I'm a little confused here. Are you saying this is a problem that needs to be addressed in SolidStart? Or would it be possible to provide a separate build for SolidStart users? Thanks! |
@cschroeter some notes here from the Solid-Start team on this issue. |
@alexvuka1 @apatrida @jgillich @ryoid @charmbyte Please try Please note that path imports like |
Thank you very much, the issue appears to be resolved, but I'm running into another issue with SegmentGroup. This worked fine before (master from yesterday built with generate: ssr) I have just the SegmentGroup sample code in a SolidStart route: import { SegmentGroup } from "@ark-ui/solid";
import { Index } from "solid-js";
export default () => {
const frameworks = ["React", "Solid", "Vue"];
return (
<>
<SegmentGroup.Root>
<SegmentGroup.Indicator />
<Index each={frameworks}>
{(framework) => (
<SegmentGroup.Item value={framework()}>
<SegmentGroup.ItemText>{framework()}</SegmentGroup.ItemText>
<SegmentGroup.ItemControl />
</SegmentGroup.Item>
)}
</Index>
</SegmentGroup.Root>
</>
);
}; The inital page loads fine, but when you change anything and trigger a live reload, you get: In my route with some other stuff, the initial load works too, but the error pops up after a second or two without changing anything, so I'm guessing it's not actually a problem with live reload but rather any state update.. |
@jgillich Bildschirmaufnahme.2023-10-25.um.15.49.26.mov |
Ah I'm sorry, cause was ParkUI pulling in a different version of ark anatomy and zagjs and node somehow loading the wrong version in the wrong place 🤷. Fix was simple:
|
Description
The build was working on @ark-ui/solid version 0.9.0, but upgrading broke it.
Link to Reproduction
https://stackblitz.com/edit/github-sebcjd?file=src%2FBasicNumberInput.tsx
Steps to reproduce
Ark UI Version
0.10.1
Framework
Browser
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: