Test for Node 0.8 support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbnicolai, I think this is more of an |
|
@dasilvacontin am I wrong in my understanding this stacktrace is not due to node 0.8 not being supported by supports-color? npm ERR! Error: No compatible version found: supports-color@'^1.2.0'
npm ERR! Valid install targets:
npm ERR! ["0.2.0","1.0.0","1.1.0","1.2.0"]
npm ERR! at installTargetsError (/home/travis/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:719:10)
npm ERR! at /home/travis/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:641:10
npm ERR! at RegClient.get_ (/home/travis/.nvm/v0.8.28/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:101:14)
npm ERR! at RegClient.<anonymous> (/home/travis/.nvm/v0.8.28/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:37:12)
npm ERR! at fs.readFile (fs.js:181:14)
npm ERR! at Object.oncomplete (fs.js:302:15)
npm ERR! If you need help, you may report this log at:
npm ERR! <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR! <npm-@googlegroups.com> |
|
I think it's |
sindresorhus
added a commit
that referenced
this pull request
Feb 11, 2015
Test for Node 0.8 support
|
Sure, since Mocha needs it. But Mocha should seriously consider dropping support for 0.8. Build fixed in 4f4c583 |
|
Thanks @sindresorhus! I'll talk with the team about dropping support for 0.8. Any other reason besides the release is over one year old? |
|
Node 0.8 was released on June 25, 2012. That's 2 years 8 months. The few people still needing 0.8 support can just stay on the current Mocha version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow node 0.8 to be used, and tested through Travis.
This is to allow mocha to adopt this package, see mochajs/mocha#1545
@sindresorhus you okay with extending support to 0.8?