You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
With the release of @changesets/get-release-plan we can get richer information about the existence non-existence of changesets: I think it would be good to change how this action works to something like:
yarn in repo and call getReleasePlan() using { sinceMaster: true }
With the output - check the length of the changesets array to see if there are new changesets ('empty' changesets is a feature we know AK wants that we want this to work with).
If there are, format the data in releasesin some way to display this information.
Open questions:
a) is this mad?
b) how do we format the info?
i) probably need to separate packages from dependents here
ii) a table maybe?
iii) Do we include any summary info or leave that for PR-inspection?
Major downside:
requires this doing a yarn install etc
The text was updated successfully, but these errors were encountered:
I strongly dislike this and would like to avoid it if possible. Could we bundle get-release-plan? I assume we would have the problem of the action getting out of date but I feel like the versioning parts are stable enough that it won't really be a problem.
a) is this mad?
I like it as an idea
b) how do we format the info?
i) probably need to separate packages from dependents here
SGTM
ii) a table maybe?
My thoughts are that it should be in a table inside a <details> element because huge automatic GitHub comments are annoying.
iii) Do we include any summary info or leave that for PR-inspection?
We can bundle getReleaseplan probably. Looking at the current script, it bundles node_modules, so we can just piggyback on that functionality but with getReleasePlan included.
Good thought around avoiding the yarn.
My thoughts are that it should be in a table inside a
element because huge automatic GitHub comments are annoying.
IMO, don't include it.
Easy agree on these
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With the release of
@changesets/get-release-plan
we can get richer information about the existence non-existence of changesets: I think it would be good to change how this action works to something like:getReleasePlan()
using{ sinceMaster: true }
changesets
array to see if there are new changesets ('empty' changesets is a feature we know AK wants that we want this to work with).releases
in some wayto display this information.Open questions:
a) is this mad?
b) how do we format the info?
Major downside:
requires this doing a yarn install etc
The text was updated successfully, but these errors were encountered: