Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Storybook 8 #2080

Closed
sungik-choi opened this issue Mar 15, 2024 · 2 comments · Fixed by #2309
Closed

Explore Storybook 8 #2080

sungik-choi opened this issue Mar 15, 2024 · 2 comments · Fixed by #2309
Assignees
Labels
good first issue Issue that good for newcomers test Issue or PR that related to test

Comments

@sungik-choi
Copy link
Contributor

Description

Explore Storybook 8

Reasons for suggestion

  • 스토리북에 내장된 Visual test가 매력적인 피쳐로 보이는데, Chromatic의 사용량을 공유하는 기능일 수도 있어 확인이 필요함
  • Upgrade dependencies #1997 (comment) : react-docgen 문제를 해결하고 넘어가야하고, 해결된다면 syncpack의 버전 제한 설정도 제거해야함

Proposed solution

생략

References

@sungik-choi sungik-choi added the test Issue or PR that related to test label Mar 15, 2024
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Mar 15, 2024
@yangwooseong
Copy link
Collaborator

yangwooseong commented Apr 30, 2024

Thank you for helping us stress-test the addon! Now that the beta period has ended, snapshots from Visual Tests addon will be tracked in your Chromatic snapshot usage. Learn more about Chromatic’s pricing tiers, or please contact our support team if you have any questions.

addon의 스냅샷이 크로마틱 스냅샷 사용량에 포함되기 때문에 유효하게 사용하려면 사용량 제한을 초과하지 않기 하기 위해 #1000 를 먼저 해결해야할 것 같네요 (참고: https://www.chromatic.com/blog/visual-tests-addon/)

@channel-io channel-io deleted a comment from channeltalk bot Apr 30, 2024
@yangwooseong yangwooseong added the good first issue Issue that good for newcomers label Jun 17, 2024
@yangwooseong yangwooseong self-assigned this Jun 26, 2024
Copy link

channeltalk bot commented Jun 26, 2024

@github-project-automation github-project-automation bot moved this from 📌 Backlog to ✅ Done in Bezier React Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that good for newcomers test Issue or PR that related to test
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants