Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate the box-shadow of the foundation ev #690

Closed
Tracked by #1800
sungik-choi opened this issue Jan 12, 2022 · 2 comments
Closed
Tracked by #1800

Seperate the box-shadow of the foundation ev #690

sungik-choi opened this issue Jan 12, 2022 · 2 comments
Assignees
@sungik-choi
Labels
enhancement Issues or PR related to making existing features better feat:foundation Issue of PR related to a new foundation

Comments

@sungik-choi
Copy link
Contributor

sungik-choi commented Jan 12, 2022 •
edited
Loading

현재 상황

foundation ev는 background-color, box-shadow 두 스타일 속성이 포함된 믹스인입니다.

문제점

작업하다보니 ev를 컴포넌트에서 지정한 색상보다 뒤에 작성해서 ev의 background-color로 의도치않게 덮어씌워지는 케이스가 많이 발생했습니다. 이는 사용하기에 직관적이지 않다고 생각합니다. 그리고 베지어 디자인 시스템 피그마 상에서도 ev(Shadows) - background-color(Colors)가 묶여있지 않습니다. 종종 ev와 background-color가 매칭되지 않는 디자인 시안들도 있습니다.

어떻게 개선할 수 있는지

  1. box-shadow 를 별도로 분리 -> ev 정의를 변경
  2. 디자인할 때에도 ev3 이상일 경우 무조건 배경색상은 bg-white-high 를 사용하는 등의 룰을 지키기 (디자인팀과 논의 필요)

Reference

없음
@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Jan 12, 2022
@sungik-choi sungik-choi added this to the 1.0.0 milestone Apr 28, 2022
@sungik-choi sungik-choi removed this from the 1.0.0 milestone May 18, 2022
@sungik-choi sungik-choi added the feat:foundation Issue of PR related to a new foundation label Nov 9, 2022
@sungik-choi sungik-choi changed the title foundation ev의 box-shadow를 분리 Seperate the box-shadow of the foundation ev Nov 9, 2022
@sungik-choi sungik-choi mentioned this issue Nov 10, 2022
Closed
@sungik-choi sungik-choi mentioned this issue Jan 19, 2023
Closed
@sungik-choi sungik-choi mentioned this issue Jun 30, 2023
Closed
@sungik-choi sungik-choi mentioned this issue Nov 2, 2023
Closed
@sungik-choi sungik-choi self-assigned this Dec 7, 2023
@sungik-choi
Copy link
Contributor Author

  • shadow 디자인 토큰을 분리하여 해결하고자 함
  • 마이그레이션이 중요할 듯

@sungik-choi sungik-choi mentioned this issue Dec 15, 2023
Closed
@sungik-choi
Copy link
Contributor Author

shadow 토큰 분리 완료, 적용 예정이므로 close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungik-choi sungik-choi

Labels
enhancement Issues or PR related to making existing features better feat:foundation Issue of PR related to a new foundation
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sungik-choi