feat(InputChip): add 1.0 component #2097
Merged
+324
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2097 +/- ##
==========================================
+ Coverage 97.03% 97.05% +0.01%
==========================================
Files 108 110 +2
Lines 2765 2780 +15
Branches 751 755 +4
==========================================
+ Hits 2683 2698 +15
Misses 78 78
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
size-limit report 📦
|
booc0mtaco
force-pushed
the
aholloway/EDS-1419
branch
from
5ae5e49
to
8972376
Compare
- add styles and structure - add in relevant stories - add tests/snapshots to test - focus-state handling with render tokens
booc0mtaco
force-pushed
the
aholloway/EDS-1419
branch
from
8972376
to
579d76d
Compare
booc0mtaco
commented
Nov 18, 2024
| @@ -12,5 +12,8 @@ | |||
| "typescript.validate.enable": true, | |||
| "javascript.validate.enable": true, | |||
| "editor.formatOnSave": true, | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
There was a problem hiding this comment.
Note: this tells VSCode to treat the *.css files as css language files. Somehow, it was thinking they were "tailwind" files 👎
ademartini-czi
approved these changes
Nov 18, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Nov 19, 2024
## [15.7.0](v15.6.0...v15.7.0) (2024-11-18) [Storybook](https://61313967cde49b003ae2a860-cpbnunloqv.chromatic.com/) ### Features * **InputChip:** add 1.0 component ([#2097](#2097)) ([2f68041](2f68041)) * **Tag:** update to 2.0 styles ([#2087](#2087)) ([a344222](a344222)) ### Bug Fixes * **deps:** update dependency ts-morph to v24 ([#2102](#2102)) ([350c72b](350c72b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
TODO-AHcommentsScreen.Recording.2024-11-15.at.11.04.17.mov
Test Plan: