Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting Assignments of num_rnn_layers Parameter #15

Open
Chrixtar opened this issue Oct 30, 2021 · 2 comments
Open

Conflicting Assignments of num_rnn_layers Parameter #15

Chrixtar opened this issue Oct 30, 2021 · 2 comments

Comments

@Chrixtar
Copy link

Hello,

thanks for publishing your code.
One thing that I have noticed is that both current config files assign the value one to the num_rnn_layers parameter, i.e., encoder and decoder of DCRNN consist of one layer each.
However, in the original DCRNN approach, the authors use two layers for each one and you compare your approach with their evaluation results.
Since I have not found any note on this difference in your paper, could you please clarify how many layers have been used for DCRNN in your evaluation of GTS?

Thank you in advance.

Best regards
Chris

@chaoshangcs
Copy link
Owner

Hi Chris. Thanks for your question. First, when we evaluate the DCRNN, we sets the hyperparameter "num_rnn_layers" as 2, which is same with original code. Second, in our GTS model, we just set this parameter as 1 for saving the memory.

Best!

@Chrixtar
Copy link
Author

Thank you for your quick response.
I have another question regarding the way how you calculate the random walk matrix for the DCGRUCell:
You first add the identity to the adjacency matrix and then normalize it with the inverse degree matrix.
However, if I am not mistaken, the original DCRNN does not add the identity matrix.
Is there a reason for this difference ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants