Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new MaskedDeck operations: StatsBase.sample!, Base.popat! and "restore!" #35

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Support new MaskedDeck operations: StatsBase.sample!, Base.popat! and "restore!" #35

merged 1 commit into from
Aug 4, 2023

Conversation

charleskawczynski
Copy link
Owner

@charleskawczynski charleskawczynski commented Aug 4, 2023 •
edited
Loading

This is now truly a masked deck (using a bitarray)

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors @charleskawczynski
Merge #35
8d67cbd 
35: Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`unpop!`" r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #35 (a47d73a) into main (cbc85ba) will increase coverage by 1.64%.
The diff coverage is 100.00%.

❗ Current head a47d73a differs from pull request most recent head 0e96744. Consider uploading reports for the commit 0e96744 to get more accurate results

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   92.47%   94.11%   +1.64%     
==========================================
  Files           2        2              
  Lines          93      119      +26     
==========================================
+ Hits           86      112      +26     
  Misses          7        7
Files Changed Coverage Δ
src/masked_deck.jl 97.77% <100.00%> (+3.04%) ⬆️

@charleskawczynski
Copy link
Owner Author

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Canceled.

@charleskawczynski charleskawczynski changed the title Support new MaskedDeck operations: StatsBase.sample!, Base.popat! and "unpop!" Support new MaskedDeck operations: StatsBase.sample!, Base.popat! and "restore!" Aug 4, 2023
@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors @charleskawczynski
Merge #35
c646487 
35: Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`restore!`" r=charleskawczynski a=charleskawczynski

This is now truly a masked deck (using a bitarray)

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Already running a review

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors @charleskawczynski
Merge #35
7435483 
35: Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`restore!`" r=charleskawczynski a=charleskawczynski

This is now truly a masked deck (using a bitarray)

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors @charleskawczynski
Merge #35
9165f5b 
35: Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`restore!`" r=charleskawczynski a=charleskawczynski

This is now truly a masked deck (using a bitarray)

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build failed:

@charleskawczynski
Copy link
Owner Author

bors r+

bors bot added a commit that referenced this pull request Aug 4, 2023
@bors @charleskawczynski
Merge #35
d315847 
35: Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`restore!`" r=charleskawczynski a=charleskawczynski

This is now truly a masked deck (using a bitarray)

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build failed:

@charleskawczynski
Copy link
Owner Author

popat! is undefined in Julia 1.4?? Ugh, I'm sorry, I'm dropping support for this and lower versions.

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit dca646e into main Aug 4, 2023
19 checks passed
@bors bors bot deleted the ck/MaskedDeck branch August 4, 2023 06:25
@charleskawczynski charleskawczynski mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski