Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to filter collectors for multiple requests #97

Open
MaJaHa95 opened this issue Aug 8, 2024 · 0 comments · May be fixed by #98
Open

[Feature Request] Option to filter collectors for multiple requests #97

MaJaHa95 opened this issue Aug 8, 2024 · 0 comments · May be fixed by #98

Comments

@MaJaHa95
Copy link

MaJaHa95 commented Aug 8, 2024

I recently deployed this exporter, and it's functioning great, but I'm finding it's pretty slow in my environment. /metrics takes ~4.5 minutes, so I've configured my scrape timeout and interval appropriately, but it's still not ideal to have the requests running that long.

I'd love to have the ability to set up multiple scrapers, and have them hit the different collectors. I was kind of wondering whether the Prometheus library supported that natively, but it seems like it maybe doesn't.

My thinking is that we'd have, say:

  • /metrics -- fully backwards compatible
  • /metrics/client
  • /metrics/controller
  • /metrics/device
  • /metrics/port

Query string parameters would also work, but I think this is simpler to implement. But I'm really not familiar with the Prometheus libraries, so maybe there's a more clever solution.

This would also have the advantage that different metrics could be scraped at different intervals, if desired.

@MaJaHa95 MaJaHa95 linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant