Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoded key is unencrypted, reconstituted key is too #7

Closed
ClashTheBunny opened this issue Mar 16, 2022 · 0 comments · Fixed by #11
Closed

Encoded key is unencrypted, reconstituted key is too #7

ClashTheBunny opened this issue Mar 16, 2022 · 0 comments · Fixed by #11
Assignees
Labels
enhancement New feature or request

Comments

@ClashTheBunny
Copy link

I think this is probably obvious to many people, but this also strips the encryption of the secret key. It would be nice to be explicit about that.

If you don't add it back after you undo the melt, you may be confused as to why it's no longer asking for a password or that errant npm package was able to ship it to a hacker. Maybe add that as an optional step after?

@caarlos0 caarlos0 added the enhancement New feature or request label Mar 16, 2022
@caarlos0 caarlos0 self-assigned this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants