Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node v20 #24

Closed
jplandry908 opened this issue Nov 27, 2023 · 8 comments
Closed

Support Node v20 #24

jplandry908 opened this issue Nov 27, 2023 · 8 comments

Comments

@jplandry908
Copy link

First off, thank you for your hard work on this. Do you have any plans to support the new Node v20 runtime?

@charoitel
Copy link
Owner

@jplandry908, currently is still under planning, may include node 20 support when the next release of node-canvas is available, thanks

@swipht1991
Copy link

Thank you for providing this. Is node 20 support still a part of the plan for a future release?

@charoitel
Copy link
Owner

@swipht1991, yes and actually Node 20 should be supported. For reference, according to Automattic/node-canvas#2232, Node 16 may be dropped in node-canvas 3.0.0.

These days I am wondering, in case the new release of node-canvas still not available in upcoming few months, may be I would release a maintenance release which would try to include support for Node 20 first.

Please feel free to let me know if there is any concern, or if there is anything would like to include or discuss. Thanks~

@swipht1991
Copy link

@charoitel That sounds great, thank you for the detailed update. I hadn't realized node-canvas wasn't providing node 20 support until 3.0.0. Since node 18 still has support I don't think there is a huge urgency to get node 20 supported, but a maintenance release of node-canvas to ensure that is available would be appreciated. It's good to know it's still on the plan and will be made available when node-canvas 3.0.0 is out.

Thanks again for providing this.

@deathemperor
Copy link

just wanna chime in that node-canvas support node 20 in its latest release https://github.com/Automattic/node-canvas/releases/tag/v2.11.2

@splunkettCB
Copy link

@charoitel since the above node-canvas release supports node20 would it be possible to have a new version of lambda layer built to support 20?

@sepiaflux
Copy link

Hi, is there any progress on this?:)

@charoitel
Copy link
Owner

Thanks everyone for your patience, my apologies to keep you waiting that long, the new release that supports node20 has just released on GitHub and Serverless Application Repository. However, in order to make the size as minimal as possible, the release has been separated into small packages by node version: 16, 18 and 20.

In addition, during the testing, it is found that the data URI being generated could be different under node20, you may refer to the fix in the konva test script. Besides node20 support, fabric v6 is also now supported.

Do you think that may be good to separate the layer packages not just by node version but also by dependency like canvas-node20 and canvas-fabric-node20? Please feel free to suggest and leave your comments. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants