Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash.sortby in whatwg-url #12

Closed
charpeni opened this issue Nov 25, 2019 · 0 comments · Fixed by #66
Closed

Replace lodash.sortby in whatwg-url #12

charpeni opened this issue Nov 25, 2019 · 0 comments · Fixed by #66
Labels
📦 Bundle Size Changes the size of the JavaScript bundle

Comments

@charpeni
Copy link
Owner

whatwg-url uses lodash.sortby in URLSearchParams.sort(), for a single call that needs a stable sort algorithm.

We could replace lodash.sortby by something more lightweight or even native, so we could save near ~13-20 KB.
@charpeni charpeni added the 📦 Bundle Size Changes the size of the JavaScript bundle label Nov 25, 2019
@charpeni charpeni linked a pull request Feb 10, 2020 that will close this issue
Bump whatwg-url-without-unicode to 8.0.0-0 #66
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 Bundle Size Changes the size of the JavaScript bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump whatwg-url-without-unicode to 8.0.0-0 charpeni/react-native-url-polyfill
1 participant
@charpeni