Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SvgPath.parse fails on negative values #1360

Merged

Conversation

Arantiryo
Copy link
Collaborator

Implements suggested fix from #1248.

@codecov-commenter
Copy link

Codecov Report

Merging #1360 (e54f50d) into main (5f716c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          42       42           
  Lines        1231     1231           
  Branches      322      322           
=======================================
  Hits          908      908           
  Misses        239      239           
  Partials       84       84           
Impacted Files Coverage Δ
src/svg/SvgPath.ts 97.70% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gionkunz
Copy link
Collaborator

Hi there! Thanks for the PR! Would you mind adding a few tests for this case? Cheers!

@Arantiryo
Copy link
Collaborator Author

Hi @gionkunz! Yes, absolutely! Do you think that covers it or should I add anything else?

@gionkunz gionkunz merged commit cf6831d into chartist-js:main Sep 27, 2022
@gionkunz
Copy link
Collaborator

Thanks, @Arantiryo , I think that's sufficient at the moment. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants