Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring consistency between line and bubble options #5572

Closed
benmccann opened this issue Jun 16, 2018 · 1 comment
Closed

Bring consistency between line and bubble options #5572

benmccann opened this issue Jun 16, 2018 · 1 comment
Labels
breaking change

Comments

@benmccann
Copy link
Contributor

Bubble options are not prefixed with "point", but line options are. E.g. line controller has pointBorderColor, pointRadius, etc... For the bubble controller, we have borderColor, radius, ...

In 3.0, we should scope those options: dataset.point.radius, dataset.point.rotation or dataset.elements.point.radius ...
@benmccann benmccann added this to the Version 3.0 milestone Jun 16, 2018
@benmccann benmccann mentioned this issue Jun 16, 2018
Merged
@benmccann benmccann mentioned this issue Oct 25, 2019
Closed
@benmccann benmccann removed this from the Version 3.0 milestone May 21, 2020
@etimberg
Copy link
Member

This is out of v3 and we aren't going to change this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmccann @etimberg