Integrate with Chef Compliance #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
vj/integrate-with-compliance
branch
from
1f4b200 to
72d77aa
Compare
chris-rock
changed the title
chris-rock
force-pushed
the
vj/integrate-with-compliance
branch
from
72d77aa to
f88b512
Compare
Signed-off-by: Victoria Jeffrey <vjeffrey@chef.io>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
vj/integrate-with-compliance
branch
from
f88b512 to
348145e
Compare
|
This PR is not touching the unit tests yet. This is covered in #128 |
|
🌟 i just tested it, works great. will look thru code in a minute, just need to finish making lunch. |
|
👍 🎉 |
|
Thanks for review @vjeffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings back the Chef Compliance integration by using the new Chef Handler architecture. It also leverages the inspec compliance fetcher. Also We save time by running inspec only once instead for each profile individually.