Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stick to plain ruby hash #219

Merged
merged 1 commit into from
May 3, 2017
Merged

stick to plain ruby hash #219

merged 1 commit into from
May 3, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented May 3, 2017 •
edited
Loading

This PR removes unnecessary json handling. Now, we can use plain ruby hashs everywhere.

@chris-rock chris-rock changed the title use plain report WIP: use plain report May 3, 2017
@chris-rock chris-rock force-pushed the chris-rock/remove-json-conversion branch from b6aab8f to 16d61b4 Compare May 3, 2017 21:56
@chris-rock chris-rock changed the title WIP: use plain report stick to plain ruby hash May 3, 2017
@chris-rock
use plain ruby hash everywhere
5176182 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock chris-rock force-pushed the chris-rock/remove-json-conversion branch from 16d61b4 to 5176182 Compare May 3, 2017 22:01
arlimus
arlimus approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another huge change to core processing aspects; I think it's for the better, thank you! 👍

@arlimus arlimus merged commit 78b2eff into master May 3, 2017
@arlimus arlimus deleted the chris-rock/remove-json-conversion branch May 3, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlimus arlimus arlimus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @arlimus