This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
chef: Use test/smoke/default instead of test/recipes for generated cookbooks/recipes
#1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing generated inspec tests in `test/recipes` causes Foodcritic to fail, as Foodcritic assumes the `test` directory is now a cookbook (which is false). Using `test/smoke/default` fixes this issue and creates direct associations with the existing Kitchen and Workflow templates. 1. The delivery-project.toml already runs `kitchen verify` during smoke. There is now a connection between the phase and the tests that are run by default. 2. The `default` folder in smoke is associated with the `default` suite already provided in the Kitchen YAML. This indicates and guides the user that additional suites can be created under smoke, and gives implicit guidance as to their naming. Signed-off-by: Tom Duffield <tom@chef.io>
|
I'm concerned about introducing more explicitly Delivery/Workflow-based terms into the broader Chef community. This change in particular is probably okay, but something we should keep an eye on over time :-/ |
|
Is there a reason not to use the default directory structure defined in kitchen-inspec? |
|
@MarkGibbons by using the term "smoke", instead of "integration", we associate those tests with the Workflow phase in which they are executed. |
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
COOL-585/tduffield/use-smoke-nomenclature
branch
from
b8c877a to
e057858
Compare
tduffield
changed the title
test/smoke/default instead of test/recipestest/smoke/default instead of test/recipes for generated cookbooks/recipes
|
@tduffield Did another maintainer review this that I didn't see? |
|
Matt and Lamont |
|
@tduffield Good to make sure stuff is visible on the public side since we can't all see the internal tickets :) |
This was referenced Jan 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storing generated inspec tests in
test/recipescauses Foodcritic tofail, as Foodcritic assumes the
testdirectory is now acookbook (which is false). Using
test/smoke/defaultfixes this issueand creates direct associations with the existing Kitchen and Workflow
templates.
kitchen verifyduringsmoke. There is now a connection between the phase and the tests that
are run by default.
defaultfolder in smoke is associated with thedefaultsuitealready provided in the Kitchen YAML. This indicates and guides the user
that additional suites can be created under smoke, and gives implicit
guidance as to their naming.
Issues Resolved
Check List
Signed-off-by: Tom Duffield tom@chef.io