Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Document chefignore #1110

Merged
merged 3 commits into from
Jan 17, 2017
Merged

Document chefignore #1110

merged 3 commits into from
Jan 17, 2017

Conversation

vinyar
Copy link

@vinyar vinyar commented Dec 9, 2016

Description

This is a first commit in a series to add comments to common files resulting from a chef hackday
Most of the comments shamelessly borrowed from (https://github.com/mwrock/chef_workstation)

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]

Check List

Alex Vinyar added 2 commits December 9, 2016 13:22
adding comments to gitignore.erb
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the
    best of my knowledge, is covered under an appropriate open
    source license and I have the right under that license to
    submit that work with modifications, whether created in whole
    or in part by me, under the same open source license (unless
    I am permitted to submit under a different license), as
    Indicated in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including
    all personal information I submit with it, including my
    sign-off) is maintained indefinitely and may be redistributed
    consistent with this project or the open source license(s)
    involved.

Signed-off-by: Alex Vinyar <alex@getchef.com>
Author: Alex Vinyar <alex@chef.com>

 Committer: Alex Vinyar <alex@chef.com>

Attempting to get past the DCO check
   Signed-off-by: Alex Vinyar <alex@chef.com>

Signed-off-by: Alex Vinyar <alex@chef.com>
@vinyar vinyar closed this Dec 9, 2016
@vinyar vinyar reopened this Dec 9, 2016
@vinyar vinyar mentioned this pull request Dec 9, 2016
4 tasks
# ##nodejs
# node_modules


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line?

# *.log
# *.sqlite3
# db/*.sqlite3
# .bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go up in the ruby section

@thommay thommay changed the title Alex chefignore v2 Document chefignore Jan 17, 2017
Signed-off-by: Thom May <thom@may.lt>
@thommay thommay merged commit 6278816 into chef-boneyard:master Jan 17, 2017
@thommay thommay added Type: Documentation Type: Enhancement Adds new functionality. and removed Documentation labels Feb 1, 2017
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
@tas50 tas50 added Aspect: Documentation How do we use this project? and removed Type: Documentation labels Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Aspect: Documentation How do we use this project? Type: Enhancement Adds new functionality.
Development

Successfully merging this pull request may close these issues.

4 participants