This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add in rhel and windows FIPS override #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoshier
force-pushed
the
bp-439/rhel-windows-fips-chefdk
branch
3 times, most recently
from
d8c8d94 to
6a7a661
Compare
|
Worth noting that this work depending on this merging first. |
tylercloke
approved these changes
Dec 23, 2016
rmoshier
force-pushed
the
bp-439/rhel-windows-fips-chefdk
branch
2 times, most recently
from
8bed168 to
c0d6f37
Compare
tyler-ball
force-pushed
the
bp-439/rhel-windows-fips-chefdk
branch
2 times, most recently
from
bebf92b to
b3c9133
Compare
tyler-ball
force-pushed
the
bp-439/rhel-windows-fips-chefdk
branch
3 times, most recently
from
0fe83a8 to
069b2bd
Compare
dmccown
approved these changes
Jan 18, 2017
|
|
||
| # TODO Pinning these for now because github_changelog_generator has a bunch | ||
| # of different versions across our products | ||
| gem "nokogiri", "~> 1.6.3" |
There was a problem hiding this comment.
@tduffield Have you all mitigated the dependency breakage? Would you like this in a different PR?
There was a problem hiding this comment.
Yup! We're going to get this merged since it got a green build and deal with the problem dependencies in another PR
dmccown
suggested changes
Jan 18, 2017
|
🚧 until we figure out what to do about the dependencies |
Also update our omnibus config to use the new fips flags getting exposed. Signed-off-by: Rachel Adler <radler@chef.io> Signed-off-by: tyler-ball <tyleraball@gmail.com>
Signed-off-by: tyler-ball <tyleraball@gmail.com>
tyler-ball
force-pushed
the
bp-439/rhel-windows-fips-chefdk
branch
from
37b4c97 to
918723a
Compare
|
This is ready for final review and merging! |
tduffield
approved these changes
Jan 19, 2017
schisamo
approved these changes
Jan 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On rhel and windows include the OpenSSL FIPS module into the ChefDK. The FIPS module is not activated unless users activate it.
Issues Resolved
N/A
Check List