This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Use latest Foodcritic, Inspec, Chefspec, and Fauxhai #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
changed the title
tduffield
approved these changes
Mar 30, 2017
acceptance/Gemfile.lock
Outdated
| @@ -79,7 +79,8 @@ GEM | |||
| hashie (3.5.5) | |||
| hitimes (1.2.4) | |||
| httpclient (2.8.3) | |||
| inspec (1.17.0) | |||
| inspec (1.18.0) | |||
There was a problem hiding this comment.
We should probably update the RELEASE_NOTES with this as well.
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
bump
branch
4 times, most recently
from
ef78770 to
e090d30
Compare
tas50
commented
Mar 31, 2017
Rakefile
Outdated
| @@ -74,8 +74,7 @@ namespace :style do | |||
| desc "Run Chef Cookbook (Foodcritic) style checks" | |||
| FoodCritic::Rake::LintTask.new(:foodcritic) do |t| | |||
| t.options = { | |||
| fail_tags: ["any"], | |||
| tags: ["~FC007", "~FC011", "~FC031", "~FC045", "~supermarket"], | |||
| tags: ["~FC064", "~FC065", "~FC066", "~FC067"], | |||
There was a problem hiding this comment.
There seems to be a bug in FC with Rake that is preventing ~supermarket from working here
Foodcritic task Signed-off-by: Tim Smith <tsmith@chef.io>
10.2.2 fixes the bug that prevented the tags from working correctly Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Smith tsmith@chef.io