Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Update dependencies to bring in Cookstyle 2.0 #1272

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Update dependencies to bring in Cookstyle 2.0 #1272

merged 1 commit into from
Jun 2, 2017

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 2, 2017

Signed-off-by: Tim Smith tsmith@chef.io

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from lamont-granquist and thommay June 2, 2017 18:17
@lamont-granquist
Copy link
Contributor

i guess we must have backed out testing with chefstyle or something

@tas50
Copy link
Contributor Author

tas50 commented Jun 2, 2017

We backed that out since the result at the time was us shipping chefstyle in DK and that was super confusing. If we can avoid that with the new bundler setup then we should get that testing going again.

@tas50 tas50 merged commit ca9d728 into master Jun 2, 2017
@tas50 tas50 deleted the cookstyle2 branch June 2, 2017 20:44
@lamont-granquist
Copy link
Contributor

we might be able to put it into its own chefstyle group and avoid installing it in the runtime when we build omnibus. i'm having to do similar things with github-freaking-changelog-generator, although i had to do some extra hackery there since it infects every Gemfile in our universe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants