This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Update config.json with proper cookstyle use #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing configuration with cookstyle in the config.json was incorrect and would not run. Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
|
@mattstratton Can you fix that rspec test to expect the correct output? |
Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
tas50
suggested changes
Aug 31, 2017
Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
|
Still off by a bit. Check the PR diff |
Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
Signed-off-by: Matt Stratton <matt.stratton@gmail.com>
tas50
approved these changes
Sep 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous JSON was incorrect and would not actually enable cookstyle.
Check List