Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Adds stove for inclusion #1385

Merged
merged 11 commits into from
Sep 14, 2017
Merged

Adds stove for inclusion #1385

merged 11 commits into from
Sep 14, 2017

Conversation

sbcas
Copy link
Contributor

@sbcas sbcas commented Sep 12, 2017

stove is enjoyed by many cookbook developers and should be included

Signed-off-by: Samuel Cassiba s@cassiba.com

stove is enjoyed by many cookbook developers and should be included

Signed-off-by: Samuel Cassiba <s@cassiba.com>
@sbcas sbcas requested a review from a team September 12, 2017 15:23
@coderanger
Copy link
Contributor

I think @tas50 and I are probably the only official-ish maintainers of Stove at this point and we kind of don't want it in ChefDK as it's not really at the UX level we want in a ChefDK-d project. The plan is to re-implement a similar tool in the chef-dk gem itself, but that hasn't happened yet.

@thommay
Copy link
Contributor

thommay commented Sep 13, 2017

I think given that it's what everyone uses to upload to supermarket, we should ship it now and as and when a replacement is built we can deprecate and do the things nicely at that point.

@cheeseplus
Copy link
Contributor

fwiw @tas50 has just landed a bunch of fixes and released 6.0.0 so I think we're trying to meet in the middle with this one as opposed to waiting for a thing that may never come.

tas50 and others added 5 commits September 13, 2017 11:34
…itic

Signed-off-by: Tim Smith <tsmith@chef.io>
Bring in the latest net-ssh, rake, kitchen-hyperv, inspec, and foodcritic
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Copy link
Contributor

tas50 commented Sep 14, 2017

I'm ok with making this change now. You'll want to rebase it though since I bumped the Gemfile.lock earlier today (sorry).

tas50 and others added 5 commits September 13, 2017 20:16
stove is enjoyed by many cookbook developers and should be included

Signed-off-by: Samuel Cassiba <s@cassiba.com>
@thommay thommay merged commit 9c25709 into chef-boneyard:master Sep 14, 2017
@thommay
Copy link
Contributor

thommay commented Sep 14, 2017

Thanks, @scassiba

@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants