Be more selective about what dev gems we bundle #1393
Conversation
`berkshelf` no longer has a guard group in the gemfile so remove that exclusion `chef` no longer has a changelog group so remove that exclusion `foodcritic` has no changelog group, but it does have a development group: ronn, pry `test-kitchen` (master currently) has a debug group and a docs group: yard, pry, pry-byebug, and pry-stack_explorer `inspec` no longer has a changelog group, but it does have deploy, tools, and maintenance groups: pry, rb-readline, license_finder, tomlrb, octokit, netrc, and inquirer Signed-off-by: Tim Smith <tsmith@chef.io>
|
The inspec one we might regret since this will yank pry from that appbundle, not sure how many normal people use pry for debugging inspec tests though. Otherwise 👍 |
|
The InSpec Shell it built on pry, but pry is already listed as a dependency in the gemspec so we should be OK. https://github.com/chef/inspec/blob/master/inspec.gemspec#L37 |
|
pretty certain that what we ship is just what is in the Gemfile.lock and that these get applied to the merged Gemfile.lock which use in order to test the gems, and that by removing the development gems from some of these that you'll have broken the chefdk test builds. and by removing gem groups here you don't affect what we ship, only what we install on the testers. |
|
so please test this manually with an ad-hoc build in manhattan before shipping |
|
tested with an adhoc in manhattan and it got through the test phase all green (still pretty sure this does not affect shipping gems at all) |
|
Even if all we do is limit test deps that's fine by me. |
berkshelfno longer has a guard group in the gemfile so remove that exclusionchefno longer has a changelog group so remove that exclusionfoodcritichas no changelog group, but it does have a development group: ronn, prytest-kitchen(master currently) has a debug group and a docs group: yard, pry, pry-byebug, and pry-stack_explorerinspecno longer has a changelog group, but it does have deploy, tools, and maintenance groups: pry, rb-readline, license_finder, tomlrb, octokit, netrc, and inquirerSigned-off-by: Tim Smith tsmith@chef.io