This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
They are integration tests, not smoke tests #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathenharvey
changed the title
|
back to the future? |
lamont-granquist
approved these changes
Oct 3, 2017
robbkidd
approved these changes
Oct 3, 2017
danielsdeleo
approved these changes
Oct 3, 2017
tas50
approved these changes
Nov 29, 2017
tas50
reviewed
Nov 29, 2017
RELEASE_NOTES.md
Outdated
| @@ -31,3 +31,8 @@ cookbooks to supermarkets. | |||
| The cookbook generator now adds a LICENSE file when creating a new | |||
| cookbook. | |||
|
|
|||
| ## Rename `smoke` tests to `integration` tests. | |||
There was a problem hiding this comment.
@nathenharvey Can you rebase this and shove this into the top of the release notes please
* Integration tests are for multiple classes/units, like a cookbook * Smoke tests quickly determine if the system is "working" * The tests now live in an `integration` directory instead of a `smoke` directory * Add the renamed integration test to the RELEASE_NOTES Signed-off-by: Nathen Harvey <nharvey@chef.io>
nathenharvey
force-pushed
the
nathen/they_are_integration_tests
branch
from
0cad62e to
3d09730
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tests for the new directory name
The tests now live in an
integrationdirectory instead of asmokedirectory.Check List